DOM attribute for the group node needed which references the undo button

VERIFIED FIXED in Firefox 9

Status

P4
normal
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: whimboo, Assigned: raymondlee)

Tracking

Trunk
Firefox 9
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill])

Attachments

(1 attachment, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #596450 +++

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100913 Firefox/4.0b6pre

When you create a set of tab groups and close multiple of those, several undo buttons appear. At the moment there is no reference added to the DOM node of the tab group which undo button corresponds to it. Given that it is not possible for Mozmill to determine the correct button.

Similar to bug 596450 we would need a DOM or JS property as reference on all hidden tab groups to identify the undo button.
Priority: -- → P4
Whiteboard: [mozmill]

Comment 1

9 years ago
Punting to the future, unless Henrik can get to it.
Assignee: nobody → hskupin
Target Milestone: --- → Future
Assignee: hskupin → nobody
(Assignee)

Comment 2

8 years ago
Created attachment 559832 [details] [diff] [review]
v1

Taking the same approach in the patch in bug 596450. Adding a DOM attribute (data-group) to undo button containers.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #559832 - Flags: review?(dietrich)
(Assignee)

Updated

8 years ago
Depends on: 596450
Comment on attachment 559832 [details] [diff] [review]
v1

Review of attachment 559832 [details] [diff] [review]:
-----------------------------------------------------------------

i'd prefer data-group-id, which is more specific. r=me with that change!
Attachment #559832 - Flags: review?(dietrich) → review+
(Assignee)

Comment 4

8 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Comment on attachment 559832 [details] [diff] [review]
> v1
> 
> Review of attachment 559832 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> i'd prefer data-group-id, which is more specific. r=me with that change!

The patch for bug Bug 596450 has been checked into fx-team which is using data-group. 
http://hg.mozilla.org/integration/fx-team/rev/43f1efa4b17d

It would be better to keep them constantly.  I would update that to data-group-id as well, once it's merged into mozilla-central.
(Assignee)

Comment 5

8 years ago
Created attachment 560319 [details] [diff] [review]
Patch for checkin

Changed the data-group to data-group-id.

Pushed to try
https://tbpl.mozilla.org/?tree=Try&rev=97a431ff9117
Attachment #559832 - Attachment is obsolete: true
Blocks: 686895
(Assignee)

Comment 6

8 years ago
(In reply to Raymond Lee [:raymondlee] from comment #5)
> Pushed to try
> https://tbpl.mozilla.org/?tree=Try&rev=97a431ff9117

Passed try!
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b9202c23f51
Keywords: checkin-needed
Target Milestone: Future → Firefox 9

Comment 8

8 years ago
https://hg.mozilla.org/mozilla-central/rev/8b9202c23f51
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Sweet. Looks perfect with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110919 Firefox/9.0a1. Thanks guys!
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.