596504 - DOM attribute for the group node needed which references the undo button

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

+++ This bug was initially created as a clone of Bug #596450 +++

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6pre) Gecko/20100913 Firefox/4.0b6pre

When you create a set of tab groups and close multiple of those, several undo buttons appear. At the moment there is no reference added to the DOM node of the tab group which undo button corresponds to it. Given that it is not possible for Mozmill to determine the correct button.

Similar to bug 596450 we would need a DOM or JS property as reference on all hidden tab groups to identify the undo button.

Comment 1

[Aza Raskin [:aza]]

Punting to the future, unless Henrik can get to it.

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

Taking the same approach in the patch in bug 596450. Adding a DOM attribute (data-group) to undo button containers.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 559832 [details] [diff] [review]
v1

Review of attachment 559832 [details] [diff] [review]:
-----------------------------------------------------------------

i'd prefer data-group-id, which is more specific. r=me with that change!

Comment 4

[Raymond Lee [:raymondlee]]

(In reply to Dietrich Ayala (:dietrich) from comment #3)
> Comment on attachment 559832 [details] [diff] [review]
> v1
> 
> Review of attachment 559832 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> i'd prefer data-group-id, which is more specific. r=me with that change!

The patch for bug Bug 596450 has been checked into fx-team which is using data-group. 
http://hg.mozilla.org/integration/fx-team/rev/43f1efa4b17d

It would be better to keep them constantly.  I would update that to data-group-id as well, once it's merged into mozilla-central.

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: Patch for checkin

Changed the data-group to data-group-id.

Pushed to try
https://tbpl.mozilla.org/?tree=Try&rev=97a431ff9117

Comment 6

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #5)
> Pushed to try
> https://tbpl.mozilla.org/?tree=Try&rev=97a431ff9117

Passed try!

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b9202c23f51

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/8b9202c23f51

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sweet. Looks perfect with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a1) Gecko/20110919 Firefox/9.0a1. Thanks guys!