Closed Bug 596572 Opened 11 years ago Closed 11 years ago

App menu menuseparators are indented too far on XP

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b7

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #475486 - Flags: review?(gavin.sharp)
Where does the 19px come from? What is it dependent on? Native styling?
There's a native padding or border (which is smaller on XP, hence this bug), the icon container's min-width, the icon size (16px) and the label's margin:

118 .menu-iconic-left {
119   min-width: 1.45em;
120 }

99 .menu-iconic-text {
100   font-weight: inherit;
101   -moz-margin-start: 2px !important;
102   -moz-padding-end: 2px;
103 }

20px would be the sum in my case, but 19 looked better to me. Anyway, the correct formula for XP would probably be this:

-moz-margin-start: -moz-calc(max(16px, 1.45em) + 4px)

but max() isn't supported anymore, so maybe we should do this:

-moz-margin-start: -moz-calc(1.45em + 4px)
Attachment #475486 - Flags: review?(gavin.sharp)
(In reply to comment #2)
> There's a native padding or border (which is smaller on XP, hence this bug),

There's actually more going on on Vista/7... the icon container has some magic padding which probably comes from widget code.
Attached patch patch v2Splinter Review
Can't use a similar formular for Vista/7 due to the magic padding. The icon box width appears to be constant independent of the font size.
Attachment #475486 - Attachment is obsolete: true
Attachment #475610 - Flags: review?(gavin.sharp)
Attachment #475610 - Flags: review?(gavin.sharp)
Attachment #475610 - Flags: review+
Attachment #475610 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/4788083ce564
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.