596573 - manifest enforcement logs warning for all the modules in sub-directories

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

all tho modules in the modules in the content tree:
https://hg.mozilla.org/labs/jetpack-sdk/file/8b13707b865c/packages/jetpack-core/lib/content

report warnings durung the tests:

$ cfx test -F content-loader
Using binary at '/Applications/Firefox.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/-y/-yjxO9IXGGSRN-hSaip1Qk+++TM/-Tmp-/tmpibxMz8.mozrunner'.
warning: undeclared require(events) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(events) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(api-utils) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(api-utils) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(url) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(url) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
warning: undeclared require(file) called from resource://jetpack-core-jetpack-core-lib/content/loader.js
..................................error: warnings and/or errors were logged.

34 of 35 tests passed.
FAIL

Comment 1

[Atul Varma [:atul]]

Looks like the reason for this is because the python function cuddlefish.manifest.scan_package() is just doing an os.listdir() of a package's contents and not using something like os.walk() to recursively bust through its subdirectories.

As a result, no manifest information is created for modules in subdirectories.

Working on a fix for this now unless warner tells me not to...

Comment 2

[Atul Varma [:atul]]

Attachment: patch

Comment 3

[Atul Varma [:atul]]

Attachment: added unit test

Comment 4

[Brian Warner [:warner :bwarner]]

Comment on attachment 475575 [details] [diff] [review]
added unit test

looks great! I don't believe the rest of the manifest-handling code will have any problems with slashes in the module names, but I'll keep it in mind while working on that side.

Comment 5

[Atul Varma [:atul]]

Thanks! Pushed:

Bug 596573 - manifest enforcement logs warning for all the modules in sub-directories
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/d1dc9a0c37bf

Comment 6

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".