596668 - Incremental building in toolkit/mozapps/extensions/test fails with cp: cannot overwrite directory

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

$ make -C toolkit
...
cp -pPR
/Users/dolske-bulk/build/mozilla-central/obj/toolkit/mozapps/extensions/test/../../../../_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell/.
/Users/dolske-bulk/build/mozilla-central/obj/toolkit/mozapps/extensions/test/../../../../_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack
cp: cannot overwrite directory
/Users/dolske-bulk/build/mozilla-central/obj/toolkit/mozapps/extensions/test/../../../../_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell-unpack/./data
with non-directory
/Users/dolske-bulk/build/mozilla-central/obj/toolkit/mozapps/extensions/test/../../../../_tests/xpcshell/toolkit/mozapps/extensions/test/xpcshell/./data

Comment 1

[Michael Wu [:mwu]]

Probably OSX only. Can't reproduce on Linux or Windows.

Comment 2

[Michael Wu [:mwu]]

Attachment: Switch to tar to copy files

OSX's cp is buggy and follows links when it shouldn't. This patch switches to tar to avoid the buggy cp. Passes try.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 475903 [details] [diff] [review]
Switch to tar to copy files

khuey would probably have a better call on this than me

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 475903 [details] [diff] [review]
Switch to tar to copy files

khuey probably doesn't want to review a patch for an osx only bug.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 475903 [details] [diff] [review]
Switch to tar to copy files

It looks fine, but I'd prefer somebody more familiar with Mac take a look at it.

Comment 6

[Dave Townsend [:mossop]]

landed: http://hg.mozilla.org/mozilla-central/rev/7bc76cad3f23

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Seems like that the patch works. Marking as verified fixed.