596706 - don't keep ref to repeating variable nor check repeating status per interval iteration

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Erik has generated this change with the comment "no need to keep ref to 'repeating' variable, nor is there a need to check the repeating status per iteration of an interval":

http://github.com/erikvold/jetpack-sdk/commit/68ccad6eec642b259ca30b6aa7dbd814d6cf6530

I'd attach a patch to this bug and request review, but neither my git fu nor GitHub's interface is up to the task.

Atul: can you generate a patch and/or review this change?

Comment 1

[Erik Vold]

Attachment: no need to keep ref to repeating

Comment 2

[Erik Vold]

git format-patch -1 68ccad6eec642b259ca30b6aa7dbd814d6cf6530

Comment 3

[Erik Vold]

I've got a better way to handle this actually, I'll attach another patch soon.

Comment 4

[Erik Vold]

Attachment: removing usage of 'repeating' variable in the timer module.

Comment 5

[Erik Vold]

Attachment: removing usage of 'repeating' variable in the timer module.

Comment 6

[Erik Vold]

with this last commit refs to timerID that are not needed (for interval callbacks) are not created.

Comment 7

[Atul Varma [:atul]]

Comment on attachment 475697 [details] [diff] [review]
removing usage of 'repeating' variable in the timer module.

Looks good, thanks Erik!

Comment 8

[Atul Varma [:atul]]

Pushed:

Bug 596706 - don't keep ref to repeating variable nor check repeating status per interval iteration
Erik Vold
http://hg.mozilla.org/labs/jetpack-sdk/rev/703efb8a9cf7

Comment 9

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".