Closed Bug 596711 Opened 9 years ago Closed 9 years ago

Double painting with drawing in the titlebar

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: mstange, Assigned: mstange)

Details

(Keywords: perf)

Attachments

(1 file)

Attached patch v1Splinter Review
This might not matter much since we're probably going to rewrite this code in bug 595156 anyway, but the current code is wasteful.
When we're drawing in the title bar, we're passing the title bar rect as bounding rect into -[ChildView drawRect:inContext:], but we're not honoring it. Instead we paint the whole invalid region into the titlebar, only to paint it *again* when we're painting the content view.
Attachment #475600 - Flags: review?(roc)
Attachment #475600 - Flags: approval2.0?
Comment on attachment 475600 [details] [diff] [review]
v1

This can go in post-b7, but as you say there'll probably be no need from it, particularly now that bug 599241 has been landed.
Attachment #475600 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/1e685d9c9e70
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.