596743 - Need external RenderDocument API for embedding

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Tatiana Meshkova (:tatiana)]

Attachment: patch

In qt embedding we should be able to render document to an external surface.
We need to add shell->RenderDocument wrapper to nsIDOMWindowUtils, because GetShell is internal API and it's not possible to use it from external embedding library.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why is it not possible to use GetShell? It's inline.

Comment 2

[Benjamin Smedberg]

It seems that the size of nsIDocument is different if you use MOZILLA_INTERNAL_API or something like that. Besides which we really don't want people using nsIDocument out of libxul.

Comment 3

[Tatiana Meshkova (:tatiana)]

Attachment: patch

updated uuid

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 475723 [details] [diff] [review]
patch

I think patch is pretty safe, and useful for embedders, and native extensions.

Can we get it in?

Comment 5

[Oleg Romashin (:romaxa)]

http://hg.mozilla.org/mozilla-central/rev/bc10c72eb8f1

Comment 7

[Boris Zbarsky [:bzbarsky]]

So... the change to nsIDOMWindowUtils is WRONG.  Very very wrong.  If you need to add a method to an IDL interface like this, you should make it noscript and notxpcom, but tossing it in a C++ block means that XPConnect will be confused about what the vtable looks like, and if anyone is foolish enough to add things after your code, or to inherit from this interface, calling things will jump to the wrong methods and crash.

Comment 8

[Benjamin Smedberg]

Comment 7 was fixed by bug 605999.