596771 - Search by GUID sometimes returns no results

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Dave Townsend [:mossop]]

The search by GUID support added in bug 581635 seems to be intermittent. The original implementation in bug 410277 claims that we can search by multiple GUIDs so we are doing so.

The following URL works and returns both add-ons:

https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:inspector%40mozilla.org,[e-mail]

The following URL works but only returns one add-on:

https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:inspector%40mozilla.org,silvermelxt%40pardal.de

The following URL returns no add-ons despite one of them having been included in the previous two cases:

https://services.addons.mozilla.org/en-US/firefox/api/1.5/search/guid:inspector%40mozilla.org,silvermelxt%40pardal.de,CrystalFox_Qute%40BigRedBrent,%7B5A170DD3-63CA-4c58-93B7-DE9FF536C2FF%7D,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D,%7B83bfadf9-a42c-0d4f-b403-08f8897f2399%7D,%7B910c29d3-bd14-4947-ac0c-4b06e0c0b20c%7D,%7Bfa1b5a4a-0955-df41-b494-d13e876b35a7%7D

Comment 1

[Dave Townsend [:mossop]]

This basically blocks metadata retrieval for a number of users, can we figure out what is going on here?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

In the second example:

silvermelxt%40pardal.de

There is nothing with that as a GUID, just [e-mail].

The latter example, I have a fix for that I'll land soon.  The _ was an acceptable character for the guid.

Mossop, do you have that ginormous regexp for acceptable guid characters?

Comment 3

[Dave Townsend [:mossop]]

(In reply to comment #2)
> In the second example:
> 
> silvermelxt%40pardal.de
> 
> There is nothing with that as a GUID, just [e-mail].

This is an interesting case, that add-on is a part of a multi-package add-on. I guess we won't be able to pull metadata for such cases.

> The latter example, I have a fix for that I'll land soon.  The _ was an
> acceptable character for the guid.
> 
> Mossop, do you have that ginormous regexp for acceptable guid characters?

This is the regexp we test IDs against: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/XPIProvider.jsm#151

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I know nothing of multi-package add-ons... but my guess is we aren't storing them in AMO, and therefore I can't index them.

Not sure if there is a solution for this that we can do easily... we should probably store this somewhere on add-on upload.

Comment 5

[Dave Townsend [:mossop]]

(In reply to comment #4)
> I know nothing of multi-package add-ons... but my guess is we aren't storing
> them in AMO, and therefore I can't index them.

https://addons.mozilla.org/en-US/firefox/addon/7517/ is a multipackage add-on. I'm guessing you have the package ID in the database but not the ID of any of the add-ons within the package, which is exactly the reverse of the IDs that Firefox does version check and metadata checks for.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/6362bfe

Comment 7

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/en-US/firefox/api/1.5/search/guid:[e-mail],%20%7B37fa1426-b82d-11db-8314-0800200c9a66%7D,[e-mail],[e-mail],[e-mail],%20%7B0b457cAA-602d-484a-8fe7-c1d894a011ba%7D,[e-mail],[e-mail],%20%7BF8A55C97-3DB6-4961-A81D-0DE0080E53CB%7D,%7B1f91cde0-c040-11da-a94d-0800200c9a66%7D,%7B1018e4d6-728f-4b20-ad56-37578a4de76b%7D