Search by GUID sometimes returns no results

VERIFIED FIXED in 5.12.2

Status

VERIFIED FIXED
8 years ago
3 years ago

People

(Reporter: mossop, Assigned: davedash)

Tracking

unspecified
5.12.2
x86
Mac OS X

Details

(Reporter)

Comment 1

8 years ago
This basically blocks metadata retrieval for a number of users, can we figure out what is going on here?
blocking2.0: --- → betaN+
Target Milestone: --- → 5.12.2
Assignee: nobody → dd
In the second example:

silvermelxt%40pardal.de

There is nothing with that as a GUID, just silvermel@pardal.de.

The latter example, I have a fix for that I'll land soon.  The _ was an acceptable character for the guid.

Mossop, do you have that ginormous regexp for acceptable guid characters?
(Reporter)

Comment 3

8 years ago
(In reply to comment #2)
> In the second example:
> 
> silvermelxt%40pardal.de
> 
> There is nothing with that as a GUID, just silvermel@pardal.de.

This is an interesting case, that add-on is a part of a multi-package add-on. I guess we won't be able to pull metadata for such cases.

> The latter example, I have a fix for that I'll land soon.  The _ was an
> acceptable character for the guid.
> 
> Mossop, do you have that ginormous regexp for acceptable guid characters?

This is the regexp we test IDs against: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/XPIProvider.jsm#151
I know nothing of multi-package add-ons... but my guess is we aren't storing them in AMO, and therefore I can't index them.

Not sure if there is a solution for this that we can do easily... we should probably store this somewhere on add-on upload.
(Reporter)

Comment 5

8 years ago
(In reply to comment #4)
> I know nothing of multi-package add-ons... but my guess is we aren't storing
> them in AMO, and therefore I can't index them.

https://addons.mozilla.org/en-US/firefox/addon/7517/ is a multipackage add-on. I'm guessing you have the package ID in the database but not the ID of any of the add-ons within the package, which is exactly the reverse of the IDs that Firefox does version check and metadata checks for.
http://github.com/jbalogh/zamboni/commit/6362bfe
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.