596772 - web content warnings written to console after ContentSymbiont changes landed

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The fix for bug 588737 causes a bunch of warnings to get written to the console when jetpack-core tests are run against Firefox 4.0b6.  Although the warnings don't generate test failures, they do make it hard to read the console output for information about test failures and make it appear as if there are problems with the tests.  So we should make the tests stop generating them.

Here's a sample warning:

console: [JavaScript Warning: "Expected declaration but found '*'.  Skipped to next declaration." {file: "http://www.mozilla.com/includes/min/min.css?g=css" line: 1}]

This suggests to me that a new test is loading web content such as http://www.mozilla.com/, and that web content is generating warnings.  It's possible that in the long run we should simply stop reporting such errors in web content, but a short term fix would be to make the test load some content that doesn't generate them.
Irakli: do you know which tests might be generating these warnings?

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 475881 [details] [diff] [review]
Fix

Looks great, r=myk!

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Low-risk, high-reward, a=myk for checkin during freeze.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/9bfe1631d20c.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".