596792 - six "test-list.test: for each using Iterator" tests fail on the latest trunk nightly

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Six "test-list.test: for each using Iterator" tests fail on the latest trunk nightly (Mac, Linux).  All tests pass on 4.0b6.  Perhaps this is related to bug 596790 and iteration.

Here's a sample error:

error: TEST FAILED: test-list.test: for each using Iterator (failure)
error: fail: key should match (0 != (void 0))
info: Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 60, in notify
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 255, in anonymous
    timer.setTimeout(function() { onDone(self); }, 0);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 280, in runNextTest
    self.start({test: test, onDone: runNextTest});
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 298, in start
    this.test.testFunction(this);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 63, in runTest
    test(runner);
  File "resource://jetpack-core-jetpack-core-tests/test-list.js", line 55, in anonymous
    test.assertEqual(k++, key, 'key should match');
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 227, in assertEqual
    this.fail(message);
  File "resource://jetpack-core-jetpack-core-lib/unit-test.js", line 145, in fail
    console.trace();

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

This is the same issue as:
https://bugzilla.mozilla.org/show_bug.cgi?id=597004

Hack with a stack parseing to find if caller is 'Iterator' no longer works.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Fixed by the fix for bug 597004.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".