Closed Bug 596864 Opened 10 years ago Closed 10 years ago

Open links from about:firstrun in remote tabs

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Just like about:home (bug 595345), clicking links on about:firstrun can result in local tabs showing remote content.  This is especially bad for beta 1 if we don't fix zooing in local tabs.

This is a hacky fix, like the one for bug 595345.  I can file a followup to come up with a more generic fix.
Attachment #475751 - Flags: review?(mark.finkle)
tracking-fennec: --- → ?
Here's the less-hacky alternative suggested by Mark: Listen for the DOMActivate event, and send a message to open a new tab instead.
Attachment #475751 - Attachment is obsolete: true
Attachment #475763 - Flags: review?(mark.finkle)
Attachment #475751 - Flags: review?(mark.finkle)
Comment on attachment 475763 [details] [diff] [review]
patch v2: override DOMActivate

>diff -r ea70f3df7037 chrome/content/Util.js
 
>+  isInParentProcess: function isInParentProcess() {

"isParentProcess" reads better to me. Ok by you?

>+    var appInfo = Cc["@mozilla.org/xre/app-info;1"];

use "let appInfo"

This is a nice improvement!
Attachment #475763 - Flags: review?(mark.finkle) → review+
Pushed with nit fixes:
http://hg.mozilla.org/mobile-browser/rev/25d089c480c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre


follow-up bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=597019
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.