596864 - Open links from about:firstrun in remote tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Just like about:home (bug 595345), clicking links on about:firstrun can result in local tabs showing remote content.  This is especially bad for beta 1 if we don't fix zooing in local tabs.

This is a hacky fix, like the one for bug 595345.  I can file a followup to come up with a more generic fix.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2: override DOMActivate

Here's the less-hacky alternative suggested by Mark: Listen for the DOMActivate event, and send a message to open a new tab instead.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 475763 [details] [diff] [review]
patch v2: override DOMActivate

>diff -r ea70f3df7037 chrome/content/Util.js
 
>+  isInParentProcess: function isInParentProcess() {

"isParentProcess" reads better to me. Ok by you?

>+    var appInfo = Cc["@mozilla.org/xre/app-info;1"];

use "let appInfo"

This is a nice improvement!

Comment 3

[Matt Brubeck (:mbrubeck)]

Pushed with nit fixes:
http://hg.mozilla.org/mobile-browser/rev/25d089c480c8

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100916 Namoroka/4.0b7pre Fennec/2.0b1pre


follow-up bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=597019