Closed Bug 596904 Opened 15 years ago Closed 14 years ago

browser.tabs.autoHide doesn't work if there is any hidden tab

Categories

(Firefox :: Tabbed Browser, defect, P2)

Product:
Firefox
Component:
Tabbed Browser
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Milestone:
Firefox 4.0

People

(Reporter: yuki, Assigned: anant)

References

Details

Attachments

(1 file, 1 obsolete file)

Update tab strip higher up in call-chain to catch all cases
1.91 KB, patch
iangilman
: feedback+
dao
: feedback-
Details | Diff | Splinter Review
"Tools" > "Options" > "Tabs" > "Always show the tab bar" means to hide the tab bar automatically when there is only one tab. However it doesn't work if there is any hidden tab. Steps to reproduce: 1. Go to "Tools" > "Options" > "Tabs" and uncheck "Always show the tab bar". 2. Open a new window. Then there is a window with only one tab. The tab bar is hidden. 3. Open a new tab. Then the tab bar is shown. 4. Click "Group Your Tabs" button. 5. Make two groups and put tabs to each group. (Then tere are two groups and each group have only one tab.) 6. Click a thumbnail in a group. Actual result: The tab bar is shown with only one visible tab. Expected result: The tab bar is hidden. ---------------- <method name="updateVisibility"> <body><![CDATA[ if (this.childNodes.length - this.tabbrowser._removingTabs.length == 1 && window.toolbar.visible) this.visible = !Services.prefs.getBoolPref("browser.tabs.autoHide"); else this.visible = true; ]]></body> </method> ------------------- "this.childNodes.length - this.tabbrowser._removingTabs.length" shoud be "this.tabbrowser.visibleTabs.length".
Component: Tabbed Browser → TabCandy
QA Contact: tabbed.browser → tabcandy
Priority: -- → P2
Assignee: nobody → raymond
Priority: P2 → P3
Blocks: 585689
Target Milestone: --- → Firefox 4.0
Priority: P3 → P4
Raymond: This bug is simple enough, I'll attach a patch soon :)
Assignee: raymond → anant
Status: NEW → ASSIGNED
Priority: P4 → P2
We update the tab strip correctly according to the user's preferences, if there is only one tab remaining in a given group. Users who have selected that the tab strip be hidden when only 1 tab is open must use a keyboard shortcut or menu item to return to the TabView in order to switch groups.
Attachment #482979 - Flags: feedback?(ian)
Comment on attachment 482979 [details] [diff] [review] Update tab strip correctly (patch v1) Rather than calling updateVisibility from within the tabview code, you should make it happen in showTab/hideTab in tabbrowser.xml; that way you know you're catching all cases.
Attachment #482979 - Flags: feedback?(ian) → feedback-
Per feedback!
Attachment #482979 - Attachment is obsolete: true
Attachment #483017 - Flags: feedback?(ian)
Comment on attachment 483017 [details] [diff] [review] Update tab strip higher up in call-chain to catch all cases (In reply to comment #3) > Users who have selected that the tab strip be hidden when only 1 tab is open > must use a keyboard shortcut or menu item to return to the TabView in order to > switch groups. This seems like a step backwards. The pref isn't "[X] Hide the tab bar when only 1 tab is visible" but "[ ] Always show the tab bar", so that's open to our interpretation.
Attachment #483017 - Flags: feedback-
Suggesting wontfix.
Component: TabCandy → Tabbed Browser
QA Contact: tabcandy → tabbed.browser
The label of the checkbox was changed from "Hide the tab bar when only one web site is open" to "Always show the tab bar" by the bug 340677, (perhaps) for making it easy for people to know how the checkbox works. The change was only about the options dialog, not about actual behaviors.
Well, even "when only one web site is open" doesn't quite apply when there are hidden tabs.
If the words "only one website is open" should mean "only one <tab> element exists in the DOM tree", I agree to make this bug wontfix. However, I think the words can be read as "only one tab seems to be there". I apologize to write a problem of addon development here: how we addon developers should treat visible tabs and hidden tabs? Is there any guideline? I thought that my addons should treat hidden tabs just same as tabs in a background windows (so I filed this bug with a same reason). I think addon developers should design behaviors of their addons to fit to the story of Firefox's UI, to avoid users' confusion. However there seems to be no coherent story about visible/hidden tabs for me...
(In reply to comment #10) > If the words "only one website is open" should mean "only one <tab> element > exists in the DOM tree", I agree to make this bug wontfix. However, I think the > words can be read as "only one tab seems to be there". I'm not talking about the DOM tree, which itself isn't accessible to the user. But the pages behind hidden tabs are actually open and the tab bar provides the primary way to access them. > I apologize to write a problem of addon development here: how we addon > developers should treat visible tabs and hidden tabs? Is there any guideline? I > thought that my addons should treat hidden tabs just same as tabs in a > background windows (so I filed this bug with a same reason). I think addon > developers should design behaviors of their addons to fit to the story of > Firefox's UI, to avoid users' confusion. However there seems to be no coherent > story about visible/hidden tabs for me... There's no spelled out guideline, no...
Comment on attachment 483017 [details] [diff] [review] Update tab strip higher up in call-chain to catch all cases f+ for the implementation, in case we decide to go with it. I don't have strong feelings either way as to whether we should do it or not.
Attachment #483017 - Flags: feedback?(ian) → feedback+
I personally believe it makes sense to implement this change. jm2c. Adding some ux folks for their opinion. Removing from our tracking bug for fx4, though.
No longer blocks: 585689
This bug is good for [ux-minimalism]. It would allow to have extra vertical space on netbooks by getting rid of the tab bar and yet would allow to easily switch between many tabs through panorama.
(In reply to Timofei Shatrov from comment #14) > and yet would allow to easily switch between many tabs through panorama. No, it wouldn't, since it would hide the panorama button. :/
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
(In reply to Dão Gottwald [:dao] from comment #15) > > No, it wouldn't, since it would hide the panorama button. :/ To avoid stepping backward: How about putting panorama button in Navigation Toolbar or anywhere else, when Tabbar is hidden ? Like bookmarks button, which appeares in Navigation Toolbar when Bookmarks Toolbar is hidden.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: