596952 - about:support, other about:pages are layed out incorrectly sometimes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Steps to reproduce:
 * set about:support as the start page
 * close, then relaunch fennec

Actual result:
 * page is layout on 980px without any scaling
  It sounds like because this is a local page without any viewport

Expected result:
 * page fit completely on the layout


I'm a bit unsure of the solution here, but since when we're switching tab the browser seems to be layout at the innerWidth, i think this can do the job.

Comment 1

[Matt Brubeck (:mbrubeck)]

Comment on attachment 475819 [details] [diff] [review]
Patch

I don't think we want to take this patch - there seems to be an underlying bug that we should fix instead.

Comment 3

[Matt Brubeck (:mbrubeck)]

From the duplicate bug 596991, this also affects about:fennec.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: temporary hack

The underlying bug is that we can't set the scale in local tabs (bug 597081).  If they use the default 980px viewport width, then we fail when trying to zoom them out to fit, resulting in the current incorrect rendering.

I think the idea in Vivien's hack above actually is the best solution for beta 1; here's an implementation that I like better.

Comment 5

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/748e503f9ae9

We can remove this hack when bug 597081 is fixed.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hack seems ok : 
Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100917 Firefox/4.0b7pre Fennec/2.0b1pre

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Matt, could you create a bug to remove this hack for when bug 597081 is fixed if there isn't one please?

Comment 8

[Matt Brubeck (:mbrubeck)]

It won't be possible to fix bug 597081 without removing this hack, so no separate bug is necessary.  (This hack disabled local tab zooming, and bug 597081 is "Implement local tab zooming.")