596981 - Enable Frisian (fy) language

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Fred Wenzel [:wenzel]]

Frisian is fully translated, but there's confusion with its locale code.

Verbatim knows it as "fy"
product-details knows it as "fy-NL"
Babel does at least not recognize "fy-NL".

Need to find a way to resolve this.

CCing Wil who might have some insight on the least invasive way to fix this? I assume I can't just change fy_NL to fy in the prod-details lib and call it a day, because it'd mess with Mozilla.com and friends? Have you solved a problem like this on AMO before?

Comment 1

[Fred Wenzel [:wenzel]]

Wim: It seems, the Babel library indeed does not have any information on number/date formats for Frisian :( Do you use the same number conventions (i.e., comma vs. decimal point) and date conventions (dd.mm.yyyy or so) as Dutch? If so, I can probably make it fall back to Dutch for these formats.

Thanks in advance for letting me know.

Comment 2

[Wim]

Fredric, yes they are the same as in Dutch.
Is there a way for me to provide them for you?
Don't hesitate to ask.

Comment 3

[Fred Wenzel [:wenzel]]

I was now able to enable Frisian on stage (by letting Babel fall back to Dutch):

http://github.com/fwenzel/reporter/commit/c392b37

One problem that remains is that Django also does not know the locale, so the "timesince" filter (e.g., "1 week, 2 days ago") just shows English. I filed bug 598029 about that.

By the way, this language will go live in production tomorrow when we push Input 1.8 live.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Given bug 582075 (and that Frisian builds will redirect to /nl/), do we still want to enable this?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on http://input.stage.mozilla.com/fy-NL/; correct auto-detection is tracked by bug 582075.