Closed
Bug 597022
Opened 14 years ago
Closed 14 years ago
browser-chrome unittests have references to tile-container
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: vingtetun)
Details
(Whiteboard: [mobile_unittests] [mobile_dev_needed])
Attachments
(1 file)
|
12.82 KB,
patch
|
mbrubeck
:
review+
mfinkle
:
review+
|
Details | Diff | Splinter Review |
with the removal of tiles, we need to remove references in our unittests. http://mxr.mozilla.org/mobile-browser/source/chrome/tests/head.js#27 http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_select.js#29 http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_mainui.js#22 http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_bookmarks_star.js#108
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [mobile_unittests] [mobile_dev_needed]
|
Assignee | |
Comment 1•14 years ago
|
||
I would like to have Matt's opinion about the change into browser_viewport.js which are mainly (only?) replacing bv.getZoomLevel() by getBrowser().scale. My goal is not to have tests working with this patch but just have them running.
Attachment #475918 -
Flags: review?(mbrubeck)
Attachment #475918 -
Flags: review?(mark.finkle)
|
||
Updated•14 years ago
|
Attachment #475918 -
Flags: review?(mbrubeck) → review+
|
||
Comment 2•14 years ago
|
||
Comment on attachment 475918 [details] [diff] [review] Patch Land right away please.
Attachment #475918 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/e302473d1a69
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•