browser-chrome unittests have references to tile-container

RESOLVED FIXED

Status

Fennec Graveyard
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jmaher, Assigned: vingtetun)

Tracking

Details

(Whiteboard: [mobile_unittests] [mobile_dev_needed])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
with the removal of tiles, we need to remove references in our unittests.
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/head.js#27
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_select.js#29
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_mainui.js#22
http://mxr.mozilla.org/mobile-browser/source/chrome/tests/browser_bookmarks_star.js#108
(Reporter)

Updated

7 years ago
Whiteboard: [mobile_unittests] [mobile_dev_needed]
Created attachment 475918 [details] [diff] [review]
Patch

I would like to have Matt's opinion about the change into browser_viewport.js which are mainly (only?) replacing bv.getZoomLevel() by getBrowser().scale.
My goal is not to have tests working with this patch but just have them running.
Attachment #475918 - Flags: review?(mbrubeck)
Attachment #475918 - Flags: review?(mark.finkle)
Attachment #475918 - Flags: review?(mbrubeck) → review+
Comment on attachment 475918 [details] [diff] [review]
Patch

Land right away please.
Attachment #475918 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/e302473d1a69
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.