Closed
Bug 597027
Opened 14 years ago
Closed 14 years ago
Restartless add-ons still work in safe mode
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b7
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: mossop, Assigned: mossop)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
14.14 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
For other add-ons it is the platforms job to make sure they aren't used in safe mode but for restartless add-ons we have to not start them. Also going to be some other safe mode related fixes rolled into this.
|
Assignee | |
Updated•14 years ago
|
blocking2.0: --- → betaN+
|
|
Assignee | |
Comment 1•14 years ago
|
||
This adds special behaviours for safe mode as well as fixing bug 595663. isActive will always be false for safe mode (though internally we still track the active property as normal), no bootstrap methods can ever be called in safe mode and add-ons can install, enable, disable or uninstall without any restarts.
Attachment #477266 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
|
||
Comment 2•14 years ago
|
||
Comment on attachment 477266 [details] [diff] [review]
patch rev 1
Nicely done!
Attachment #477266 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [checkin-needed-post-b7]
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [checkin-needed-post-b7] → [has patch][checkin-needed-post-b7]
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][checkin-needed-post-b7]
Target Milestone: --- → mozilla2.0b8
|
||
Comment 4•14 years ago
|
||
Verified fixed with builds on all platforms like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•