Closed Bug 597027 Opened 12 years ago Closed 12 years ago

Restartless add-ons still work in safe mode

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: mossop, Assigned: mossop)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

For other add-ons it is the platforms job to make sure they aren't used in safe mode but for restartless add-ons we have to not start them. Also going to be some other safe mode related fixes rolled into this.
blocking2.0: --- → betaN+
Attached patch patch rev 1Splinter Review
This adds special behaviours for safe mode as well as fixing bug 595663. isActive will always be false for safe mode (though internally we still track the active property as normal), no bootstrap methods can ever be called in safe mode and add-ons can install, enable, disable or uninstall without any restarts.
Attachment #477266 - Flags: review?(robert.bugzilla)
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Comment on attachment 477266 [details] [diff] [review]
patch rev 1

Nicely done!
Attachment #477266 - Flags: review?(robert.bugzilla) → review+
Whiteboard: [checkin-needed-post-b7]
Whiteboard: [checkin-needed-post-b7] → [has patch][checkin-needed-post-b7]
Blocks: safe-mode
Blocks: 554097
Fixed: http://hg.mozilla.org/mozilla-central/rev/dc107ab54201
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch][checkin-needed-post-b7]
Target Milestone: --- → mozilla2.0b8
Verified fixed with builds on all platforms like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101010 Firefox/4.0b8pre
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.