597109 - JSProxyHandler should deal with PropertyStub

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

Currently, when JSProxyHandler calls into a C++ implementation of getPropertyDescriptor, it doesn't check whether desc.{getter,setter} is PropertyStub. For a C++ implementation of a proxy handler, it doesn't know whether the desc is going to be used as a parameter to JS_DefineProperty, so it has to use PropertyStub. Therefore, JSProxyHandler should deal with both null and PropertyStub as being equivalent.

This patch has r=gal.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/tracemonkey/rev/89535221195d

Comment 2

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/89535221195d

Comment 3

[Brendan Eich [:brendan]]

No testcase. This hides a difference between Waldo's PropDesc, which never returns js::PropertyOp function pointers (see PropDesc::initialize), and the mrbkap-via-luke PropertyDescriptor counterpart, which does. Yuck.

Need that test, and I think there are bugs in jsproxy.cpp still not handling both null and PropertyStub.

/be

Comment 4

[Brendan Eich [:brendan]]

Did I mention we have one too many *Prop*Desc* thingies?

/be

Comment 5

[Brendan Eich [:brendan]]

(In reply to comment #3)
> Need that test, and I think there are bugs in jsproxy.cpp still not handling
> both null and PropertyStub.

I'm wrong, the code is just (increasingly) confusing, not wrong.

Still want a test here.

/be