597133 - Can't open New Window if part of the window is off the left edge of the screen

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[shadowdragonwater]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100916 Firefox/4.0b7pre
Build Identifier: 4.0b7pre (released 9-16-2010)

After opening a flash video (for example, live.twit.tv), if I move the firefox window to the bottom left corner of my screen, I can not open a new window. When I click on 'New Window' the allready opened video becomes 'active'. However If I move the window to any other part of the screen, I can open a new window. Or If i have more then one window open, I can continue to open new windows. It only happens when the video/stream is the only window opened at the time. 

Reproducible: Always

Steps to Reproduce:
1. Close all other windows.
2. went to live.twit.tv
3. move window so the actual video is almost touching the end of the screen
4. Either right click on the firefox icon on the dock, or file -> new window. 
Actual Results:  
The video/streaming window becomes the 'active' firefox window and no other windows are opened.

Expected Results:  
I expect a new window to be opened

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this a regression?  That is, do older nightlies behave correctly?

Comment 2

[shadowdragonwater]

I'm not 100% sure when this started, but I would say, its been happening for sure the last 3-4 days.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Are you willing to try old nightlies to narrow it down?

Comment 4

[shadowdragonwater]

Sure, is there an easy way of trying them without having to manually download each one and install them?

Comment 5

[Boris Zbarsky [:bzbarsky]]

I'm afraid not.  :(

Comment 6

[shadowdragonwater]

Ok, so after download a bunch of firefox installs. The program started on 7-16-2010. 

Last working one is from 7-15-2010 link:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010/07/2010-07-15-03-mozilla-central/firefox-4.0b2pre.en-US.mac.dmg  

Then starting with this one it stopped working: 
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010/07/2010-07-16-03-mozilla-central/firefox-4.0b2pre.en-US.mac.dmg

Also I have made a new discovery! Its not flash related, and its not just the bottom left corner. If I move any firefox window to the left side of the screen, and move the window off the screen, where (in os x), the red close button, is off the screen, then when i try to open a new window, nothing happens. Hopefully that makes some since, if not maybe I can explain it better/do a screen shot.

Comment 7

[shadowdragonwater]

I've done a few more tests, it seams that this problem is also happening with the 64-bit of firefox, I've been using the 32-bit version. 

I also had a spare macbook, so i tried the recent nightly, and the same issue on there. I also tested on windows 7 64-bit, and that worked fine. I also tested on ubuntu 9.04, and no issues, so looks like only a mac (os x) bug. 

I did find something else out, If you have the option 'Warn me when closing multiple tabs' checked. Then move part of the window off the left side of the screen, try to create a new window, and then try to quit. The little popup window that asks if you want to save your tab/windows does get displayed, but the majority of it is shown off the screen, all that i see is just a small sliver of gray window. When using the 'show all open windows' shortcut in OS X, I can see that popup, but no other firefox windows. 

Also I'm not sure if I can change it or not, but could someone update the subject, since it is no longer a flash problem

Comment 8

[Boris Zbarsky [:bzbarsky]]

> If I move any firefox window to the left side of the screen, and move the
> window off the screen, where (in os x), the red close button, is off the
> screen, then when i try to open a new window, nothing happens.

Aha!  Yes, I can reproduce this; if there's only one Firefox window open.

The regression range there looks like http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fda39cd703c&tochange=96de199027d7

Jim, I bet this is a regression from bug 574690....

In a debug build, when the new window fails to open I see:

###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715
###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715
WARNING: Positioned frame that does not handle positioned kids; looking further up the parent chain: file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 5540
###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715
###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715
###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715
###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /Users/bzbarsky/mozilla/vanilla/mozilla/layout/base/nsPresShell.cpp, line 7715

Comment 9

[Boris Zbarsky [:bzbarsky]]

Oh, and the reason this should block is that if I then quit in that state (after a window failed to open) then on startup no window opens (with the same errors in the console).   So it's possible to get yourself into a pretty broken state.  I just edited the persisted location in localStore.rdf to fix, but most users would have no idea what happened.

Comment 10

[shadowdragonwater]

Actually this just doesn't happen when there is only one window open. I can reproduce this when there are multiple windows open, but as long as the one that is off the edge of the screen is 'active'/'on top', no new windows. 

Also apparently this is the reason why I've had to restore my localstore.rdf file couple of times the past couple of days, hehe. Assumed that was a different issue, since it only messed up the file 2-3 times.

Comment 11

[Benjamin Smedberg]

Assigning to jmathies for now, but I'd love a mac-head to look at this since mac isn't Jim's native habitat.

Comment 12

[Jim Mathies [:jimm]]

yet another side effect from the patch in bug 574690, which I'm planning to back out.

Comment 13

[Jim Mathies [:jimm]]

(In reply to comment #12)
> yet another side effect from the patch in bug 574690, which I'm planning to
> back out.

This was backed out, can anyone confirm this fix?

Comment 14

[shadowdragonwater]

Thank you!!! After some testing, this problem has been solved. Thank you again!

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #14)
> Thank you!!! After some testing, this problem has been solved. Thank you again!

Great! Thanks for filing and testing.

Comment 16

[Steven Michaud [:smichaud] (Retired)]

This appears to be related to bug 606314 -- though it isn't a dup.