Closed Bug 597144 Opened 15 years ago Closed 15 years ago

Set viewport width and height if both are specified in meta tag

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Some faulty logic causes Fennec to ignore the meta[name="viewport"] width and height on pages where both are set. Here's a simple fix and a test update. This doesn't actually test that we handle the "height" value correctly, but I will file a followup bug to add testing for that. This is low risk, but low priority for beta 1 - I have not come across any pages in the wild that actually set the "height" property.
Attachment #475951 - Flags: review?(mark.finkle)
Attachment #475951 - Flags: review?(mark.finkle) → review+
Whiteboard: [fennec-checkin-postb1]
Flags: in-testsuite+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: