Set viewport width and height if both are specified in meta tag

RESOLVED FIXED

Status

Firefox for Android Graveyard
General
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Bug Flags:
in-testsuite +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 475951 [details] [diff] [review]
patch

Some faulty logic causes Fennec to ignore the meta[name="viewport"] width and height on pages where both are set.  Here's a simple fix and a test update.

This doesn't actually test that we handle the "height" value correctly, but I will file a followup bug to add testing for that.

This is low risk, but low priority for beta 1 - I have not come across any pages in the wild that actually set the "height" property.
Attachment #475951 - Flags: review?(mark.finkle)
Attachment #475951 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

8 years ago
Whiteboard: [fennec-checkin-postb1]
(Assignee)

Updated

8 years ago
Flags: in-testsuite+
pushed:
http://hg.mozilla.org/mobile-browser/rev/c57faa2f32f0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb1]
You need to log in before you can comment on or make changes to this bug.