597217 - widget not added and "therefore cannot be removed" exceptions

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

On Linux Firefox 4.0 (nightlies and 4.0b6), exceptions like the following about widgets not being added and therefore not being able to be removed are being intermittently thrown:

error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 60, in notify
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/content/worker.js", line 61, in emitter
    emit.apply(scope, params);
  File "resource://jetpack-core-jetpack-core-lib/events.js", line 142, in _emit
    listener.apply(null, params);
  File "resource://jetpack-core-jetpack-core-tests/test-widget.js", line 432, in 
    widgets.remove(widget1);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 77, in 
    exports.remove = function(item) browserManager.removeItem(item);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 243, in browserManager_removeItem
    "and therefore cannot be removed.");
  File "", line 0, in Error
Error: The widget [object Widget "panel widget 1"] has not been added and therefore cannot be removed.
.error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 60, in notify
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/content/worker.js", line 61, in emitter
    emit.apply(scope, params);
  File "resource://jetpack-core-jetpack-core-lib/events.js", line 142, in _emit
    listener.apply(null, params);
  File "resource://jetpack-core-jetpack-core-tests/test-widget.js", line 469, in 
    widgets.remove(widget3);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 77, in 
    exports.remove = function(item) browserManager.removeItem(item);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 243, in browserManager_removeItem
    "and therefore cannot be removed.");
  File "", line 0, in Error
Error: The widget [object Widget "panel widget 3"] has not been added and therefore cannot be removed.
error: warnings and/or errors were logged.


Irakli, Dietrich: any thoughts on what might be going on here?  We didn't change Widget much this cycle, but we did change Panel a lot, and these widgets have panels.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Update: I'm seeing one of these consistently when testing against Firefox 3.6, making this a release blocker.

Irakli: any chance you could take a look at this?

Here's a sample session:

(jsdk)myk@myk:~/Projects/jsdk/packages/jetpack-core$ cfx test -b ~/Applications/firefox-3.6/firefox -F 'widget' 2>&1 | grep -v 'JavaScript Warning' | grep -v 'labelGetUbuntu is null' | grep -v 'nsITimerCallback::notify'

(firefox-bin:4494): GLib-WARNING **: g_set_prgname() called multiple times

(firefox-bin:4494): GLib-WARNING **: g_set_prgname() called multiple times
..error: An exception occurred.
Traceback (most recent call last):
  File "resource://jetpack-core-jetpack-core-lib/timer.js", line 60, in notify
    this._callback.apply(null, this._params);
  File "resource://jetpack-core-jetpack-core-lib/content/worker.js", line 61, in emitter
    emit.apply(scope, params);
  File "resource://jetpack-core-jetpack-core-lib/events.js", line 142, in _emit
    listener.apply(null, params);
  File "resource://jetpack-core-jetpack-core-tests/test-widget.js", line 469, in 
    widgets.remove(widget3);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 77, in 
    exports.remove = function(item) browserManager.removeItem(item);
  File "resource://jetpack-core-jetpack-core-lib/widget.js", line 243, in browserManager_removeItem
    "and therefore cannot be removed.");
  File "", line 0, in Error
Error: The widget [object Widget "panel widget 3"] has not been added and therefore cannot be removed.
error: warnings and/or errors were logged.

158 of 159 tests passed.
FAIL
Using binary at '/home/myk/Applications/firefox-3.6/firefox'.
Using profile at '/tmp/tmpTTTEJB.mozrunner'.
Total time: 4.020350 seconds
Program terminated unsuccessfully.

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Not sure what exactly caused this but I don't see that with this fix:
https://bugzilla.mozilla.org/show_bug.cgi?id=596666

Probably something in panel was causing that.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

As mentioned in previous comment this bug was fixed by 596666.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".