597220 - Panorama should never try to hide app tabs

Status: RESOLVED INVALID

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Ian Gilman [:iangilman]]

Working on another bug (bug 595943), I discovered that it's possible for xul:tabs to have both .pinned and .hidden true. They're still visible in this state (evidently pinned takes precedence), but it's possible they behave badly in other ways. 

So I guess there's really two issues here: Panorama should never put tabs in that state, and also it probably shouldn't even be possible to do so. This bug is for the former; bug 597218 is for the latter.

Comment 1

[Ian Gilman [:iangilman]]

Actually, I'm not sure how this is happening; hideTab (in tabbrowser.xml) has an explicit check against pinned tabs. pinTab doesn't have an explicit check for hidden tabs, but how is anyone going to pin a hidden tab? Panorama doesn't do any explicit pinning at any rate, and the only way we hide tabs as far as I can tell is through tabbrowser's showOnlyTheseTabs, which calls hideTab. 

Is sessionstore in charge of restoring pinned state? If so, perhaps Panorama hides some tabs before their pinned state is restored?

At any rate, looks like the Panorama side of this issue is clean; we should just make it not possible on the tab browser side.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

sessionstore does restore pinned & hidden. We explicitly call pin/unPinTab, however we just set hidden directly. If that's a problem we can fix it.