597245 - content-loader/worker/symbiont-based API tests generate a ton of warnings on Firefox 3.6

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Content loader/worker/symbiont-based API tests (panel, page-worker, as well as the loader/worker/symbiont modules themselves) generate a ton of warnings when run on Firefox 3.6.  For example, here are some results from testing worker itself:

(jsdk)myk@myk:~/Projects/jsdk/packages/jetpack-core$ cfx test -F worker -b ~/Applications/firefox-3.6/firefox
Using binary at '/home/myk/Applications/firefox-3.6/firefox'.
Using profile at '/tmp/tmpoxG6iy.mozrunner'.

(firefox-bin:3087): GLib-WARNING **: g_set_prgname() called multiple times

(firefox-bin:3087): GLib-WARNING **: g_set_prgname() called multiple times
console: [JavaScript Warning: "reference to undefined property "contentScriptWhen"" {file: "file:///mnt/hgfs/myk/Projects/jsdk/packages/jetpack-core/lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/content/worker.js" line: 317}]
console: [JavaScript Warning: "reference to undefined property "contentScriptURL"" {file: "file:///mnt/hgfs/myk/Projects/jsdk/packages/jetpack-core/lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/content/worker.js" line: 317}]
console: [JavaScript Warning: "reference to undefined property "onError"" {file: "file:///mnt/hgfs/myk/Projects/jsdk/packages/jetpack-core/lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/securable-module.js -> resource://jetpack-core-jetpack-core-lib/content/worker.js" line: 317}]
...

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix

I feel pretty odd submitting this patch since warning are generated for expressions like: let { foo, bar } = { bar: 'test' };
warning will be accessing undefined 'foo' property.

Please note that patch doesn't contains fix for panel warnings since it is addressed by: https://bugzilla.mozilla.org/show_bug.cgi?id=596666

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 476826 [details] [diff] [review]
Fix

> I feel pretty odd submitting this patch since warning are generated for
> expressions like: let { foo, bar } = { bar: 'test' };
> warning will be accessing undefined 'foo' property.

Yup, agreed.  However, while we continue to explicitly support Firefox 3.6, we should strive to make the SDK work well with that platform.

This looks good and seems to fix the problem in my tests. r=myk, and a=myk for landing during the freeze.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/3b5b8a77a13a (which is slightly different from the patch in this bug to resolve the trivial conflict with the fix for bug 596754).

Comment 4

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".