597250 - V8 dtoa import breaks Windows pymake build

Status: RESOLVED DUPLICATE of bug 597246

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

I can't build js/src for a browser on Windows with pymake. It does build with 'make -C js/src', but once I try to build the whole browser again with pymake, it fails.

This is bad, because tinderbox builds use pymake. I believe that if we did a clobber build right now, TM tinderbox would start burning on Windows.

The problem is that in pymake, it tries to compile, e.g., utils.cc as BUILD_DIR/js/src/utils.cc, when of course it should use SOURCE_DIR/js/src/v8-dtoa.cpp. So, maybe there is a bug with this in pymake.

Anyway, this is going to catch fire soon enough, so we should either (1) back out, (2) fix pymake, or (3) rename the .cc files to .cpp (and update Makefile.in). I verified locally that (3) does allow us to build with pymake.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

FTR, Tinderbox builds do not use pymake.