597281 - Cannot pinch to zoom during loading

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

Attachment: Patch

This is because metaData does not have allowZoom before metadata event is received.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Add a comment to the code to explain why allowZoom could be undefined

Comment 2

[Benjamin Stover (:stechz)]

Attachment: better fix

Comment 3

[Benjamin Stover (:stechz)]

Comment on attachment 476288 [details] [diff] [review]
better fix

In retrospect, I'll see your comment and raise you a better patch.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 476288 [details] [diff] [review]
better fix

Yeah, that is nicer.

Comment 5

[Matt Brubeck (:mbrubeck)]

Actually, I think this would be even better in resetMetadata in content.js.

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to comment #5)
> Actually, I think this would be even better in resetMetadata in content.js.

Err... cancel that, I think your last patch is fine as is.

Comment 7

[Benjamin Stover (:stechz)]

Attachment: only set default metadata in one place

Comment 8

[Benjamin Stover (:stechz)]

Comment on attachment 476302 [details] [diff] [review]
only set default metadata in one place

Last one does not work because most of the time metadata is set to {} by content.js.

Comment 9

[Benjamin Stover (:stechz)]

Pushed: http://hg.mozilla.org/mobile-browser/rev/357a43bbd419

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101007 Namoroka/4.0b7pre Fennec/4.0b2pre

Comment 11

[Aakash Desai [:aakashd]]

litmus testcase created https://litmus.mozilla.org/show_test.cgi?id=13632 to
regression test this bug

Comment 12

[Dão Gottwald [:dao]]

bugspam