597285 - Double-escaping add-ons summaries in the Discovery Pane

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

STR:

1. Load https://preview.addons.mozilla.org/en-US/firefox/discovery/3.6/Linux
2. Look at the "Amplify" add-on's summary

Expected Results:


Actual Results:

"Use Amplify to clip, share amp; spark conversation about excerpts from articles, blog posts"

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Er, yeah, didn't mean to include a blank "Expected Results," obviously -- but we all know what should happen.

Comment 2

[Justin Scott [:fligtar]]

Yeah.

Comment 3

[Jeff Balogh (:jbalogh)]

The real problem is that the add-on blocks want to be a giant <a> so that the whole thing is clickable, but we have addon.summary inside which is allowed to embed links.

To make the whole page not break we disabled links inside those blocks, but that's throwing off our escaping. Bug 595339 should be helpful.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Is this still happening?  I changed some of the text on the discovery pane to see if I could recreate it and everything looked fine.

Stephen, can you adjust things on preview (via the admin) to recreate?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Is this still happening?  I changed some of the text on the discovery pane to
> see if I could recreate it and everything looked fine.
> 
> Stephen, can you adjust things on preview (via the admin) to recreate?

As soon as I find the elusive/hidden discovery-pane management URL, sure (or if fligtar reminds me where it is).

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

i was thinking you could just edit one of the add-ons featured.... or are they displaying some other string other than add-on summary?

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> i was thinking you could just edit one of the add-ons featured.... or are they
> displaying some other string other than add-on summary?

Gah, you're right; OK, changed https://preview.addons.mozilla.org/en-US/firefox/addon/5428/?src=discovery-pane to be "& <a href="http://llnw.com">LimeLight</a>, and it properly leaves the ampersand alone, but the latter still shows up on https://preview.addons.mozilla.org/en-US/firefox/discovery/3.6/Linux as text, though isn't linked.

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/b3c9995

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, Dave; this is actually going out in 5.12.1, right?

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/discovery/3.6/Linux.