597427 - Sync UI: Use Weave.Utils.generatePassphrase and friends

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

{generate|hyphenate|normalize}Passphrase() are now available in Weave.Utils (see bug 593820) and can be removed from UI code.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Philipp von Weitershausen [:philikon]]

Blocks the simplified crypto work (bug 603489) and blocks us from changing the passphrase munging functions in Sync itself, so it should block b8.

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 489966 [details] [diff] [review]
v1

Tested this patch locally with my altered fx-sync repo (including generatePassphrase) and a current mozilla-central, and all seems well.

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 489966 [details] [diff] [review]
v1

Actually, I realized the patch only accommodates for generated passphrases (yes, the add-on UI code checks for passphrase length 20 *hangs head in shame*). I'll upload a fixed patch later.

Fortunately we're getting rid of custom passphrases.

Comment 5

[Philipp von Weitershausen [:philikon]]

I'm going to address this as part of bug 612699.

Comment 6

[Philipp von Weitershausen [:philikon]]

Bug 612699 landed.

Comment 7

[Tracy Walker [:tracy]]

verified with recent nightly builds