Sync UI: Use Weave.Utils.generatePassphrase and friends

VERIFIED FIXED

Status

Cloud Services
Firefox Sync: UI
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(1 obsolete attachment)

{generate|hyphenate|normalize}Passphrase() are now available in Weave.Utils (see bug 593820) and can be removed from UI code.
Created attachment 489966 [details] [diff] [review]
v1
Assignee: nobody → philipp
Attachment #489966 - Flags: review?(mconnor)
Blocks the simplified crypto work (bug 603489) and blocks us from changing the passphrase munging functions in Sync itself, so it should block b8.
Blocks: 603489
blocking2.0: --- → ?
Comment on attachment 489966 [details] [diff] [review]
v1

Tested this patch locally with my altered fx-sync repo (including generatePassphrase) and a current mozilla-central, and all seems well.
Attachment #489966 - Flags: review+
Comment on attachment 489966 [details] [diff] [review]
v1

Actually, I realized the patch only accommodates for generated passphrases (yes, the add-on UI code checks for passphrase length 20 *hangs head in shame*). I'll upload a fixed patch later.

Fortunately we're getting rid of custom passphrases.
Attachment #489966 - Flags: review?(mconnor)

Updated

7 years ago
blocking2.0: ? → final+
I'm going to address this as part of bug 612699.
No longer blocks: 603489
Depends on: 612699
(Assignee)

Updated

7 years ago
Attachment #489966 - Attachment is obsolete: true
Bug 612699 landed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
verified with recent nightly builds
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.