If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

NJ needs tweak to work with new valgrind scheme

RESOLVED FIXED

Status

Core Graveyard
Nanojit
P3
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: Tommy Reilly, Unassigned)

Tracking

unspecified
Bug Flags:
flashplayer-qrb +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 476292 [details] [diff] [review]
Don't define VALGRIND_DISCARD_TRANSLATIONS if its already defined

Trying to prepare the patient for landing valgrind
(Reporter)

Updated

7 years ago
Attachment #476292 - Flags: review?(edwsmith)
(Reporter)

Updated

7 years ago
Blocks: 509020
(Reporter)

Updated

7 years ago
Attachment #476292 - Attachment is patch: true
Attachment #476292 - Attachment mime type: application/octet-stream → text/plain

Comment 1

7 years ago
Comment on attachment 476292 [details] [diff] [review]
Don't define VALGRIND_DISCARD_TRANSLATIONS if its already defined

Looks fine.  Note that this duplicates part of the patch for bug 578673, and also duplicates Julian's version of the same tweak, in the first attachment of 509020. 

R+ if you turn it into the one-liner like in Julian's patch.
Attachment #476292 - Flags: review?(edwsmith) → review+

Updated

7 years ago
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Flags: flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.2.x-Spicy
(Reporter)

Comment 2

7 years ago
http://hg.mozilla.org/tamarin-redux/rev/49509a7cd831
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 3

7 years ago
adding more links, changing product field, leaving open until merged to TM.

NC: http://hg.mozilla.org/projects/nanojit-central/rev/aaa4e162e47e
Status: RESOLVED → REOPENED
Component: Virtual Machine → Nanojit
Product: Tamarin → Core
QA Contact: vm → nanojit
Resolution: FIXED → ---
Whiteboard: fixed-in-nanojit, fixed-in-tamarin
Target Milestone: flash10.2.x-Spicy → ---
(Reporter)

Comment 4

7 years ago
merged happened earlier today (or yesterday) courtesy Bill
(Reporter)

Comment 5

7 years ago
nevermind, TM == tracemonkey not tamarin, removing block on valgrind bug since its fixed in TR
No longer blocks: 509020
(Reporter)

Updated

7 years ago
Assignee: treilly → nobody
(Reporter)

Comment 6

7 years ago
http://hg.mozilla.org/tracemonkey/rev/a4981e82b048
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.