597503 - update mozrunner install to pick up changes from bug 583142

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

running into the same behaviour as bug 583142 when trying to run the cfx testall in staging:

Welcome to the Jetpack SDK. Run 'cfx docs' for assistance.
Testing cfx...
............................................................
----------------------------------------------------------------------
Ran 60 tests in 3.924s

OK
Testing reading-data...
Traceback (most recent call last):
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/bin/cfx", line 6, in <module>
    cuddlefish.run()
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/cuddlefish/__init__.py", line 341, in run
    test_all(env_root, defaults=options.__dict__)
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/cuddlefish/__init__.py", line 215, in test_all
    test_all_examples(env_root, defaults)
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/cuddlefish/__init__.py", line 250, in test_all_examples
    env_root=env_root)
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/cuddlefish/__init__.py", line 602, in run
    addons=options.addons)
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/cuddlefish/runner.py", line 291, in run_app
    kp_kwargs=popen_kwargs)
  File "/Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/jetpack/jetpack-sdk-9bfe1631d20c/python-lib/mozrunner/__init__.py", line 339, in __init__
    raise Exception("Binary path does not exist "+self.binary)
Exception: Binary path does not exist /Users/cltbld/talos-slave/mozilla-central_snowleopard_test-jetpack/build/Minefield.app/Contents/MacOS/firefox-bin/Contents/MacOS/firefox-bin

Comment 1

[Brian Warner [:warner :bwarner]]

Attachment: don't double-add "Contents/MacOS/" to mozrunner path

I'm not precisely sure what this does, but I believe it corresponds to the patch for bug 583142. (personally I'd use { 'Contents/MacOS/' not in binary }, but keeping our copy as similar as possible to the upstream version seemed more important).

Comment 2

[Atul Varma [:atul]]

Comment on attachment 476386 [details] [diff] [review]
don't double-add "Contents/MacOS/" to mozrunner path

Looks good to me!

Comment 3

[Brian Warner [:warner :bwarner]]

cool, thanks. I'm guessing this isn't 0.8-worthy, but I'll let Lukas and Myk tell me otherwise. It's pretty small.

Comment 4

[Brian Warner [:warner :bwarner]]

landed, in http://hg.mozilla.org/labs/jetpack-sdk/rev/25992c62b587

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".