597607 - "Stop Wearing Theme" is not displayed in context menu

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100917 Firefox/4.0b7pre

When you install a Persona on top of the default theme there is no way to "Stop Wearing Theme" context menu item shown.

Steps:
1. Install a personas from http://www.getpersonas.com/en-US/
2. Right click the installed persona

The above mentioned item is not shown. As Blair mentioned this is because of an API bug which needs to be fixed. Please mark as dependent if it has already been filed.

Comment 1

[Dave Townsend [:mossop]]

I don't know what API bug that is

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> I don't know what API bug that is

Blair mentioned something related to the new appearance pane which hasn't been landed. Lets wait for his concrete answer.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Originally this was fixed as part of the new appearance pane - I assumed that was one of the few API changes that would be carried over. Specifically, that the API would allow disabling a persona directly, rather than the current indirect method of enabling the default theme.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Originally this was fixed as part of the new appearance pane - I assumed that
> was one of the few API changes that would be carried over. Specifically, that
> the API would allow disabling a persona directly, rather than the current
> indirect method of enabling the default theme.

That was fixed as a part of bug 553494

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> That was fixed as a part of bug 553494

Huh, indeed. Skimming over that, it looks like it changed it so they can be disabled directly, but didn't make it so they advertize it (via PERM_CAN_DISABLE).

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Fixed via bug 611559.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0) Gecko/20100101 Firefox/4.0