597624 - pp -t certificate should identify and indent the DistributionPoints in the CRL distribution points extension

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Wan-Teh Chang]

Attachment: Proposed patch

pp -t certificate should identify and ident the DistributionPoints
in the CRL distribution points extension.

This elimates the following ambiguity when the CRL distribution points
extension contains multiple URLs:

   CRLDistributionPoints ::= SEQUENCE SIZE (1..MAX) OF DistributionPoint

   DistributionPoint ::= SEQUENCE {
        distributionPoint       [0]     DistributionPointName OPTIONAL,
        reasons                 [1]     ReasonFlags OPTIONAL,
        cRLIssuer               [2]     GeneralNames OPTIONAL }

   DistributionPointName ::= CHOICE {
        fullName                [0]     GeneralNames,
        nameRelativeToCRLIssuer [1]     RelativeDistinguishedName }

   GeneralNames ::= SEQUENCE SIZE (1..MAX) OF GeneralName

Note that both CRLDistributionPoints and GeneralNames are
SEQUENCE OF.  So if "pp -t certificate" prints multiple URLs,
it's not clear whether the URLs are in a single or multiple
DistributionPoint.

The patch also adds 'const' to the char* msg arguments to three functions.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 476465 [details] [diff] [review]
Proposed patch

r=nelson

Comment 2

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.13) and the
NSS_3_12_BRANCH (NSS 3.12.10).

Checking in secutil.c;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.104; previous revision: 1.103
done
Checking in secutil.h;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.h,v  <--  secutil.h
new revision: 1.35; previous revision: 1.34
done

Checking in secutil.c;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.c,v  <--  secutil.c
new revision: 1.99.2.3; previous revision: 1.99.2.2
done
Checking in secutil.h;
/cvsroot/mozilla/security/nss/cmd/lib/secutil.h,v  <--  secutil.h
new revision: 1.32.2.2; previous revision: 1.32.2.1
done