Closed Bug 597634 Opened 13 years ago Closed 12 years ago

Intermittent browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected example.org

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: birtles, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 2 obsolete files)

[checked in] potential fix
1.62 KB, patch
zpao
: review+
Details | Diff | Splinter Review
[checked in] Revised patch
2.82 KB, patch
zpao
: review+
Details | Diff | Splinter Review 
This has popped up a couple of times:

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected mozilla.org
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_522545.js | sessionstore got correct userTypedClear - Got undefined, expected 0

once on Windows Opt:
Rev3 WINNT 6.1 mozilla-central opt test mochitest-other on 2010/09/17 18:51:50
s: talos-r3-w7-032
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1284774710.1284776559.6920.gz

once on OSX Debug:
Rev3 MacOSX Leopard 10.5.8 mozilla-central debug test mochitest-other on 2010/09/17 19:52:41
s: talos-r3-leopard-008
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1284778361.1284780471.23182.gz

Suspect this push caused it:
http://hg.mozilla.org/mozilla-central/rev/a73c063e52cb
http://hg.mozilla.org/mozilla-central/rev/957c89c4eac3
http://hg.mozilla.org/mozilla-central/rev/16071f59d247
This started after bug 586068 landed. I had a couple issues with that test locally, but fixed the problem. I ran these tests again before pushing and everything passed, so yay new orange!
Summary: Intermittent failure: TEST-UNEXPECTED-FAIL | content/browser/browser/components/sessionstore/test/browser/browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected mozilla.org → Intermittent browser_522545.js | sessionstore got correct userTypedValue - Got undefined, expected mozilla.org
That explosion was because you're hitting the network - do you actually need to?
Though, wtf part of it is hitting the network? Sometimes the input event is actually loading mozilla.org? Typing mozilla.org is triggering awesomebar suggestions that are hitting the network to load favicons? I sure don't see anything other than mozilla.org that wouldn't be local or proxied.
This is clearly stupid, and couldn't possibly fix the problem, but I want to try it anyway.

You can see that setting gURLBar.value and firing an input event doesn't trigger any sort of network activity, doesn't do anything unfortunate like opening the awesomebar's suggestions and trying to load favicons, by just imitating what the test does in the error console.

But, you can also see that there are no other non-proxied hostnames in the test, and that this is the only part of the test that intermittently fails, and that back when the build network was broken, it failed on every run. So, my justification for wanting to change it is to eliminate the obvious, so when someone smarter looks at it they won't have to stop to think about whether that "mozilla.org" could be hitting the network.
Attachment #498682 - Flags: review?(paul)
Comment on attachment 498682 [details] [diff] [review]
[checked in] potential fix

(In reply to comment #274)
> But, you can also see that there are no other non-proxied hostnames in the
> test, and that this is the only part of the test that intermittently fails, and
> that back when the build network was broken, it failed on every run. So, my
> justification for wanting to change it is to eliminate the obvious, so when
> someone smarter looks at it they won't have to stop to think about whether that
> "mozilla.org" could be hitting the network.

I agree that this really should have absolutely no effect on this failure, but I'm willing to try it to eliminate the obvious. Let's give this a shot.
Attachment #498682 - Flags: review?(paul) → review+