597655 - Sync UI: Internationalize sizes in Server Quota dialog

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[u60234]

The Server Quota dialog display sizes with a period as a decimal separator. In many locales this should be a comma instead.

Comment 1

[Philipp von Weitershausen [:philikon]]

That's absolutely true. The Quota dialog uses whatever the Download Manager uses and I just checked, that doesn't properly localise the numbers either!

Comment 2

[Philipp von Weitershausen [:philikon]]

I can't quite figure out how to properly internationalise decimal numbers. Apparently number.toLocaleString() exists (and seems to be occasionally used in m-c) but on a German Firefox (on a German OS X) 2.3.toLocaleString still returns "2.3" and not "2,3" as expected.

CCing Axel, perhaps he can shed some light on this?

Comment 3

[Axel Hecht [:Pike]]

All the toLocaleString() methods use OS APIs right now, and thus the OS locale.

As it's the same as in download manager, not a regression, thus not a blocker, but a good to fix post 4, if we get a good API in gecko/l20n for this.

Comment 4

[Philipp von Weitershausen [:philikon]]

Thanks for clarifying. Clearing blocking2.0 accordingly.

Comment 5

[u60234]

But are we actually calling number.toLocaleString() here? It may not work on OS X, see bug 368838, but on Windows and Linux it does.

The sizes in Page Info, where number.toLocaleString() are used are correctly localized on Windows 7 and Ubuntu 8.04.

Comment 6

[Philipp von Weitershausen [:philikon]]

(In reply to comment #5)
> But are we actually calling number.toLocaleString() here?

No we're not (and neither does the Download Manager), but I have a patch that makes the quota dialog use it.

> It may not work on OS X, see bug 368838, but on Windows and Linux it does.

I see. I don't have a non-English Windows or Linux installation handy, so I won't be able to verify this.

Comment 7

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 8

[u60234]

Attachment: screenshot

I can verify that the patch fixes this bug on Windows.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 476639 [details] [diff] [review]
v1

We should fix this in the shared DownloadUtils code.

Comment 10

[Philipp von Weitershausen [:philikon]]

(In reply to comment #9)
> We should fix this in the shared DownloadUtils code.

Well, DownloadUtils.convertByteUnits() returns [number, unit] and it's up to the UI code to properly display 'number'. I'd say we should *also* fix this in DownloadUtils.

Unless you're suggesting to change the contract of DownloadUtils.convertByteUnits() and make it return [localized_number, unit].

Comment 11

[Philipp von Weitershausen [:philikon]]

Actually, DownloadUtils.convertByteUnits() returns [string, string] despite what the comments say. So I think we're ok making this change there.

Comment 12

[Philipp von Weitershausen [:philikon]]

Bug 597852 landed which fixes this.

Comment 13

[Tracy Walker [:tracy]]

verified per comment #8