597788 - Pressing the 'Sync Now' button in the new firefox menu/button breaks the firefox menu/button

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Steps to reproduce:
-launch minefield
-set up sync through the 'Minefield' menu
-click 'Minefield' then select 'Sync Now'

Actual results:
-clicking on the 'Minefield' button does nothing but change the appearance of the button to look like a press
-'Minefield' menu does not appear

Expected Results:
-'Minefield' button continues to show the appropriate menu when pressed.

Workaround:
-press alt to bring up old style menu bar
-select one first level menu entry (file,edit,view...)
-press 'Minefield' and notice that the menu is back.

This only happens once per instance of firefox and is always the first time I click on 'Sync now'.  It is always on the first attempt and so far has been 100% reproducable.

Comment 1

[Philipp von Weitershausen [:philikon]]

I can confirm this. Starting a manual sync using the Sync Now menu item from the Firefox/Minefield menu prevents this menu from opening for the duration of the sync process. After the sync is complete I can open the menu just fine again. Starting a manual Sync from the toolbar button doesn't seem to cause this behaviour.

Comment 2

[Mike Connor [:mconnor]]

I think the Firefox UI stripped the setTimeout from doSync, which means that menu is locked while the function executes...

Comment 3

[Tracy Walker [:tracy]]

If you have the Menu Bar shown, this bug disables the Tools menu 'til sync is complete.

Comment 4

[Dario]

This bug appears in the in Beta 7 on win 7 64 bit in the same way as described by John.

btw bug#597663 is the same bug

Comment 6

[Mike Connor [:mconnor]]

Either we should call syncOnIdle(0) or call sync() from a timeout.

Comment 8

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #6)
> Either we should call syncOnIdle(0) or call sync() from a timeout.

syncOnIdle(0) will
(a) fall back to syncOnIdle(5)
(b) bail if there's already an idle observer
(c) create an idle observer

Subsequently, it won't actually "sync now", so I'm going to vote for setTimeout (which is what the extension does... I guess I thought that unnecessary during the conversion as was pointed out in comment 2. oops!)

Comment 9

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

Comment 10

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/7cd5faf6f58c