597791 - When MOZ_MEDIA isn't set, the build is broken

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mounir Lamouri (:mounir)]

MOZ_MEDIA is defined if --enable-raw OR --enable-ogg OR --enable-webm OR --enable-wave.

nsEventListenerManager.cpp:477 tries to use NS_MOZAUDIOAVAILABLE outside of a MOZ_MEDIA ifdef.

Build with: --disable-raw --disable-ogg --disable-webm --disable-wave to reproduce

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch just add 2 ifdef MOZ_MEDIA directives

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Sorry, I've uploaded the wrong patch

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 489469 [details] [diff] [review]
Patch

You want a content or media peer to look at this, this is slightly out of my experience.

Comment 4

[Mounir Lamouri (:mounir)]

Comment on attachment 489469 [details] [diff] [review]
Patch

I think Olli might be appropriate.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

The event listener manager part is ok, but I think the content sink should work
the same way even without MOZ_MEDIA.

Ehsan should know more since he fixed Bug 598090.

Comment 6

[(no longer active)]

Yes, the content sink needs to work even if MOZ_MEDIA is not defined.

Comment 7

[(no longer active)]

You can just remove the content sink part of this patch.  I'm addressing that in bug 606109.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 489469 [details] [diff] [review]
Patch

r=me for the EventListenerManager part

Comment 9

[Mounir Lamouri (:mounir)]

Attachment: Part 1 - Fix nsEventListenerManager.cpp

r=smaug

Comment 10

[Mounir Lamouri (:mounir)]

Attachment: Part 2 - Add progress to nsGkAtoms even if MOZ_MEDIA is disabled

bug 514437 is going to move progress to nsGkAtoms even if MOZ_MEDIA is disabled. I don't think it will cost to do that in that bug thus fixing the compilation issue.

Comment 11

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/8774ecf70aa3
http://hg.mozilla.org/mozilla-central/rev/1d6823f0c00f

With a=bustage