Closed Bug 597791 Opened 10 years ago Closed 10 years ago
_MEDIA isn't set, the build is broken
MOZ_MEDIA is defined if --enable-raw OR --enable-ogg OR --enable-webm OR --enable-wave. nsEventListenerManager.cpp:477 tries to use NS_MOZAUDIOAVAILABLE outside of a MOZ_MEDIA ifdef. Build with: --disable-raw --disable-ogg --disable-webm --disable-wave to reproduce
The patch just add 2 ifdef MOZ_MEDIA directives
Sorry, I've uploaded the wrong patch
Comment on attachment 489469 [details] [diff] [review] Patch You want a content or media peer to look at this, this is slightly out of my experience.
Comment on attachment 489469 [details] [diff] [review] Patch I think Olli might be appropriate.
Attachment #489469 - Flags: review?(Olli.Pettay)
The event listener manager part is ok, but I think the content sink should work the same way even without MOZ_MEDIA. Ehsan should know more since he fixed Bug 598090.
Yes, the content sink needs to work even if MOZ_MEDIA is not defined.
You can just remove the content sink part of this patch. I'm addressing that in bug 606109.
Depends on: 606109
Comment on attachment 489469 [details] [diff] [review] Patch r=me for the EventListenerManager part
Attachment #489469 - Flags: review?(Olli.Pettay) → review+
Attachment #489469 - Attachment is obsolete: true
bug 514437 is going to move progress to nsGkAtoms even if MOZ_MEDIA is disabled. I don't think it will cost to do that in that bug thus fixing the compilation issue.
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #490384 - Flags: review?(Olli.Pettay)
Attachment #490384 - Flags: review?(Olli.Pettay) → review+
Pushed: http://hg.mozilla.org/mozilla-central/rev/8774ecf70aa3 http://hg.mozilla.org/mozilla-central/rev/1d6823f0c00f With a=bustage
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.