597843 - python-lib/cuddlefish/app-extension/defaults/preferences/prefs.js has no effect in restartless extensions

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Nickolay_Ponomarev]

Per bug 564675, python-lib/cuddlefish/app-extension/defaults/preferences/prefs.js has no effect in restartless extensions. It should probably be removed and the prefs set by it should probably be set via another mechanism. python-lib/cuddlefish/prefs.py?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Nickolay_Ponomarev]

https://github.com/mozilla/addon-sdk/pull/100

Comment 3

[Nickolay_Ponomarev]

Attachment: pointer to the pull request

From the commit descriptions:

While we're here, a couple of changes to default profile prefs:
1) make 'javascript.options.strict' work again by moving it to prefs.py
2) remove prefs not specific to xulrunner from XulrunnerAppProfile
3) create DEFAULT_COMMON_PREFS for preferences common to all applications

and
4) Since we stopped using defaults/preferences in the extension template to set development prefs, there's no need to ignore it while building XPI, which is helpful for people packaging non-bootstrapped extensions, which have default preferences they need in production.

Comment 4

[Atul Varma [:atul]]

Comment on attachment 506266 [details]
pointer to the pull request

Overall this looks good, but I have a major concern with this comment:

  https://github.com/mozilla/addon-sdk/pull/100#commitcomment-257811

Sorry for the super long delay in getting around to this, by the way. Let me know what you think of my comment and we'll move on from there!

Comment 5

[Nickolay_Ponomarev]

Oops, thanks for catching that!

Please feel free to commit that change (with the fix) yourself or wait for me to get an updated pull request ready, whatever is easier for you.

BTW, what's the procedure for updating pull requests for addon-sdk -- committing fixes on top of the original commits in the pull request, right? (per http://support.github.com/discussions/pull-requests/91-pull-requests-dont-keep-commit-history#comment_4627652 )

Comment 6

[Atul Varma [:atul]]

Thanks Nickolay! I committed it here:

  https://github.com/mozilla/addon-sdk/commit/b45513a7fec74928cc5472ef9a6c145607c49492

And yeah, I like the "committing fixes on top of the original commits in the pull request" approach, it seems to work well for us.

Comment 7

[Nickolay_Ponomarev]

Thanks again!