597930 - Link hover in location bar: some URLs not handled properly because of broken regexp

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Gordon P. Hemsley [:GPHemsley]]

Since the move of the link hover data from the status bar to the location bar, it does not appear that JavaScript URLs are handled properly.

For example, this code:
<a href="javascript:popup('http://www.worldcommunitygrid.org/help/viewTopic.do?shortName=points#177','points',550,650)" class="contentLinkBold">Points<br>Generated</a>

Shows this in the location bar:
http://www.worldcommunitygrid.org/help/viewTopic.do?shortName=points#177','points',550,650)

Notice how the parsing of the href starts at the "http://", instead of the "javascript:", but then swallows up the rest of the JavaScript code, too.

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

The regexp used to parse the URL is busted.  This is embarrassing.

Thanks for filing the bug.

Comment 2

[Shawn Wilsher :sdwilsh]

We could probably write a simple little test for this so we don't regress it in the future, right?

Comment 3

[Drew Willcoxon :adw]

Attachment: patch with test

No code changes, only tests.

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 476924 [details] [diff] [review]
patch with test

Requesting approval2.0, simple one-line fix to a bug, comes with test.

Comment 5

[Drew Willcoxon :adw]

http://hg.mozilla.org/mozilla-central/rev/c89a4257d902

Comment 6

[Drew Willcoxon :adw]

Had to back out because I can't land a bug without causing orange.

http://hg.mozilla.org/mozilla-central/rev/9c4a8b86ac0d

Comment 7

[Drew Willcoxon :adw]

Landed again last night, no orange in nearly 24 hours, calling fixed.

http://hg.mozilla.org/mozilla-central/rev/deb3fe09a0d9

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://groups.google.com/group/mozilla.dev.tree-management/browse_thread/thread/9f281275d565657c# says this may have caused substantial memory use regressions on OS X 10.5.

Comment 9

[Drew Willcoxon :adw]

Thanks Kyle.  There's no way this bug caused that regression, so I'll comment at the other bug in the push, bug 597338, which is the likelier candidate.  (But I don't think it regressed either.)