598058 - [JM] MSVC warning C4355: 'this' : used in base member initializer list

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

e:/builds/moz2_slave/tracemonkey-win32-nightly/build/js/src/methodjit/Compiler.cpp(88) : warning C4355: 'this' : used in base member initializer list

e:/builds/moz2_slave/tracemonkey-win32-nightly/build/js/src/methodjit/FrameState.cpp(50) : warning C4355: 'this' : used in base member initializer list

The FrameState warning can be fixed by initializing 'reifier' in the ::init method rather than the initializer list. I'm not sure how to fix the Compiler problem.

Comment 1

[Luke Wagner [:luke]]

One way to silence this is:

  class A : B {
    A *thisInConstructor() const { return this; }
    A : B(thisInConstructor()) {}
  };

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

There is a macro in the IPC library that can be used to silence these warnings in a convenient way. See bug 736895.

Comment 3

[:Cykesiopka]

The Compiler.cpp line was:
  stubcc(cx, *this, frame, script)

This was fixed in https://hg.mozilla.org/mozilla-central/rev/5c77882891f7


The FrameState.cpp line was:
  : cx(cx), script(script), masm(masm), entries(NULL), reifier(cx, *this),

This was fixed in Bug 601066.