598122 - nsDocument.cpp: In member function ‘nsresult nsDocument::CheckFrameOptions()’: warning: unused variable ‘thisPrincipal’

Status: RESOLVED DUPLICATE of bug 581226

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

This changeset for Bug 593387:
 http://hg.mozilla.org/mozilla-central/rev/f5c0015afe0e

added this chunk:
> 2402     // Find the top docshell in our parent chain that doesn't have the system
> 2403     // principal and use it for the principal comparison.  Finding the top
> 2404     // content-type docshell doesn't work because some chrome documents are
> 2405     // loaded in content docshells (see bug 593387).
> 2406     nsIPrincipal* thisPrincipal = NodePrincipal();
Based on the comment there, it sounds like |thisPrincipal| might be something we're interested in using. However, GCC says (and a string-search confirms) that |thisPrincipal| is unused.

bsterne: Is this as simple as just "remove line 2406", or should we actually be using thisPrincipal somewhere?

Comment 1

[Brandon Sterne (:bsterne)]

Good catch dholbert.  Yes, that line was left over from a previous version of the patch which used a different (principal-based) approach.  We can just remove it.

Comment 2

[Felipe Corrêa da Silva Sanches]

Attachment: remove it

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 476911 [details] [diff] [review]
remove it

Requesting approval to remove an unused variable that was introduced by a blocker's checkin. (bug 593387)

Comment 4

[Johnny Stenback (:jst)]

This is being fixed in bug 581226, duping (for lack of a better way to deal with a case like this).