Build ID: new trunk Steps to Reproduce: (1) Open the Preferences window (2) Navigator > History (3) Press the Clear History button The button should be disabled any time there are no items in History (e.g. if you just haven't gone anywhere yet, if you just pressed Clear History, or if you manually deleted the History items from the window). This would also be consistent with the "Clear Location Bar" button right below it, which is disabled when there are no entries in the Location bar history that can be deleted.
hrm, should this go to Preferences or History? taking choice number #1... change if needed, tho'!
Component: XP Apps: GUI Features → Preferences
18 years ago
nav triage: not a beta stopper.
Keywords: nsbeta1 → nsbeta1-
Created attachment 26373 [details] [diff] [review] changing button.disabled = SHistory.count == 0; to button.disabled = true; after blake's comments
cc'ing alec for r=/sr=
Keywords: patch, review
I applied and tried the patch, and it disables as it should when I click the button. But when I reopen the prefs, the button is still enabled.
don't confuse session and global history - session history is per-window... this button deals with clearing global history, as I understand it. I also don't like the idea of accessing specific UI elements in prefutilities.js - prefutilities means that it could be used across pages.
Marking nsbeta1- bugs as future to get off the radar
Target Milestone: --- → Future
walk84, can you update this patch?
Assignee: ben → walk84
Can anyone comment on how far in the future this bug is likely to be pushed? Thanks!
*** Bug 110443 has been marked as a duplicate of this bug. ***
Assignee: walk84 → blaker
Created attachment 67694 [details] [diff] [review] patch
Unfortunately, since pages can be hidden, it can look as if your history is empty when it's not. I don't really know if we want to fix this bug. What is the benefit? The risk is that users won't understand why the button is disabled, because they won't check and see that their history is empty first. IE doesn't bother with this subtle notification. But I think nsIBrowserHistory could use a count attribute anyway....alec, can you look at this?
If, as Blake says, "Unfortunately, since pages can be hidden, it can look as if your history is empty when it's not," then would it not be even _more_ useful for the user to be able to to tell (by the enabled/disabled state of the button) when they have truly cleared their history? The benefit, as Blake himself pointed out when he logged the bug, is that the button would then be consistent with the "Clear Location Bar" button, and it would give the user feedback that pressing the button had done something. IMHO, good UI design calls for this feature.
Unfuturing (since the future milestone was set by a different assignee anyway). Could we get a UI call on this bug? Are we doing it or not? If we're doing it, let's not let the patch rot too much. If we're not, let's wontfix this.
Target Milestone: Future → ---
I think nsIBrowserHistory could use a count attribute even if we don't do this. just needs sr from alec.
Comment on attachment 67694 [details] [diff] [review] patch sr=alecf on the whole thing.. its worth being slightly confusing for "hidden" pages..
Attachment #67694 - Flags: superreview+
oh, and on a side note - currently the only way a page can be "hidden" is by a HTTP 304 redirect - which means that they're going to be redirected to ANOTHER page which will probably end up in the history. so it's VERY unlikely that people are going to have a history that looks empty, but actually has nothing but hidden entries...
Well, actually, I seemed to have more hidden pages than I expected even after clearing my history and visiting a few sites that didn't seem to have redirects. I wonder if some pages are getting hidden incorrectly...
I'm confused - how do you know you had hidden pages? Also, redirects very often come in the form of banner ads - more and more often I'm seeing sites that have an IFRAME with SRC="http://some.ad.com/?4982309" which immediately redirects to something like "http://some.ad.com/foo/my_ad.gif" - so if the sites in question have any kind of ad, then there's your hidden page.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Blake... when I click clear history, the button doesn't disable after it deletes everything. If I do 'OK', then come back in to prefs, it's disabled. It's important to disable it actively, for user feedback. Location bar history works like this. Going to reopen.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Yep, thanks. I noticed that last night. Fixed.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago → 17 years ago
Resolution: --- → FIXED
the Clear History (and also the Clear Location Bar) button now become disabled after clicking. vrfy'd fixed using 2002.03.13 comm bits on linux rh7.2, win2k and mac 10.1.3.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.