598180 - Make it easier to update product versions

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[Jeff Balogh (:jbalogh)]

We should get this from AMO, and I probably need to make you an API endpoint to expose it.  AMO can return a JSON file that you can save to disk.

Comment 1

[Wil Clouser [:clouserw]]

-> jeff for the json

Comment 2

[Wil Clouser [:clouserw]]

Let's manage this by hand until we get this API up.

Comment 3

[Jeff Balogh (:jbalogh)]

I have a command that will dump a json file like the attachment.  The validator should read a json file like that instead of having the apps and versions hard-coded.

The file path should be a constant defined somewhere in the validator that I can monkeypatch.  AMO will import the validator and point it at the versions file we're going to update on a cron job.

The structure of the json is

{id: {guid: "{..}", versions: [..]}, ...}

Firefox starts out like this:

{"1": {"guid": "{ec8030f7-c20a-464f-9b0e-13a3a9e97384}", "versions": ["0.3", "0.6", ...]}, ...}

Comment 4

[Matt Basta [:basta]]

This is done but I need to write tests. When launching from the command line, use the "approved_applications" command line argument.

I also updated the validate.validate() function to make it easier to implement in Zamboni:

https://github.com/mattbasta/amo-validator/commit/3e976845bcb1929323282317f15cea5370b49cc7

You can just pass validate.validate("foo.bar", approved_applications="path/to/json").

By default, the validator will fall back on the values that I'd previously had in the targetapplication.py file.

Let me know if there's anything else, otherwise this is good to go.

Comment 5

[Matt Basta [:basta]]

Jeff: I updated the validate.py file with your suggestions.

https://github.com/mattbasta/amo-validator/commit/ccfbc81d9b3e0382154b920a6742cbe69cd3ea6a

Comment 6

[Matt Basta [:basta]]

There are tests for this and everything passes:

https://github.com/mattbasta/amo-validator/commit/be849f49b54faa5324633730d930deaf1d034ae9