Intermittent crashtest timeout in content/xul/document/crashtests/583230.xul | timed out waiting for reftest-wait to be removed (after onload fired)

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: zpao, Assigned: Jesse Ruderman)

Tracking

({intermittent-failure})

Trunk
x86
Mac OS X
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1285024826.1285025371.11515.gz

s: talos-r3-leopard-034
REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/mozilla-central_leopard_test-crashtest/build/reftest/tests/content/xul/document/crashtests/583230.xul | timed out waiting for reftest-wait to be removed (after onload fired)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

8 years ago
Summary: REFTEST TEST-UNEXPECTED-FAIL | 583230.xul | timed out waiting for reftest-wait to be removed (after onload fired) → Intermittent crashtest timeout in content/xul/document/crashtests/583230.xul | timed out waiting for reftest-wait to be removed (after onload fired)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

8 years ago
Assignee: nobody → jruderman
(Assignee)

Comment 13

8 years ago
There are two things wrong with content/xul/document/crashtests/583230.xul:

1. document.documentElement is null by the time we get to
     document.documentElement.removeAttribute("class");
   so that line throws rather than doing anything useful.

2. "setTimeout(doe, 0);" races with onload, so the crashtest doesn't always test the same thing, and #1 is an intermittent failure rather than a consistent failure.
Blocks: 583230
(Assignee)

Comment 14

8 years ago
Both bug 446483 and this bug were intermittent oranges due to incorrect conversions of Martijn's testcases into crashtests :(

Martijn, it would be great if you could use the reftest format in future bug reports.  In particular, try to start the test from onload rather than an inline script, even if "starting the test" is starting a timer.  It's also helpful to include the reftest-wait magic (if it's needed due to the test using timers).
(Assignee)

Comment 15

8 years ago
Created attachment 478996 [details] [diff] [review]
conservative fix

This fixes problem #1 but not problem #2.
(Assignee)

Comment 16

8 years ago
Created attachment 478998 [details] [diff] [review]
complete fix

This switches from a timer to onload, guaranteeing that doe() runs after all the document's nodes are in place (and perhaps that the relevant XBL and datasources are loaded).

Hopefully those races were not relevant to the original bug!

Since the test no longer uses a timer, reftest-wait is unnecessary.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 21

8 years ago
Pushed "complete fix": http://hg.mozilla.org/mozilla-central/rev/23ac8c47c8c9
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.