598261 - Cannot cross compile JS for Android on OSX host

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch rev 1

There are a couple of build config errors in JS that make it impossible to compile for android on an OSX host.

Firstly it attempts to link against -lobjc and defines LIBXUL_LIBS whenever the build host is OSX when it should only do that if the build target is OSX.

Secondly only certain parts of the toolchain are passed through to the libffi build. In particular RANLIB needs to point to the NDK versions or the OS versions are used. This doesn't seem to cause a problem if Linux is the host since it seems to work just like the NDK version, but the OSX version adds some "SYMDEF SORTED" entry that confuses things (it is normally ignored on an OSX compile http://mxr.mozilla.org/mozilla-central/source/js/src/config/rules.mk#1193). The patch just makes sure to pass through all the binaries for the toolchain.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 2

Forgot one thing, on OSX force-big-endian and force-little-endian are ignored right now producing some amusing results.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 479231 [details] [diff] [review]
patch rev 2

I'd like approval to land this for 2.0 so that OSX developers can hack on Android without needing a VM, I think the risk should be minimal, any issues should be caught immediately on landing (all tests have passed on tryserver already anyway)

Comment 4

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/f0be8a373b08