598263 - Make method JIT play well with valgrind in --enable-valgrind builds

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

On a local DEBUG --enable-valgrind build of m-c 573b9178b897, I see

Assertion failure: !ic.pools[index], at /home/cjones/mozilla/mozilla-central/js/src/methodjit/MonoIC.cpp:302

when starting fennec.  dvander tells me that method JIT isn't valgrind-enabled yet.

--smc-check=all works around things on my machine.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: patch (against TM 69277:fc1369652e84)

I haven't tested this yet.

Comment 2

[Jesse Ruderman]

This is an alternative to using --smc-check=all-non-file, right?  How big is the perf win for Valgrind users?