598279 - Building Javascript as shared library broken wrt xpconnect: xpcjsruntime.cpp:806: undefined reference to `js::TriggerOperationCallback(JSContext*)'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Mark Banner (:standard8)]

Non-libxul builds, which also are --disable-shared-js are broken when linking:

../../js/src/xpconnect/src/libxpconnect_s.a(xpcjsruntime.o): In function `XPCJSRuntime::WatchdogMain(void*)':
/buildbot/linux-comm-central-bloat/build/mozilla/js/src/xpconnect/src/xpcjsruntime.cpp:806: undefined reference to `js::TriggerOperationCallback(JSContext*)'
/usr/bin/ld: libgklayout.so: hidden symbol `js::TriggerOperationCallback(JSContext*)' isn't defined
/usr/bin/ld: final link failed: Nonrepresentable section on output

This is a regression from bug 589193.

The change made xpcjsruntime.cpp (in the xpconnect libary) reference a mozjs *inline* function:

http://hg.mozilla.org/mozilla-central/annotate/e6cfaf0840cb/js/src/xpconnect/src/xpcjsruntime.cpp#l806

http://hg.mozilla.org/mozilla-central/annotate/e6cfaf0840cb/js/src/jscntxt.h#l1194

As the function is inline, it cannot be referenced externally. Builds with static js get away with this as mozjs and xpconnect parts are linked into the same library.

Comment 1

[Mark Banner (:standard8)]

Attachment: Proposed fix

I was slightly wrong previously about the inline function. It is actually this function that is not public:

http://hg.mozilla.org/mozilla-central/annotate/e6cfaf0840cb/js/src/jscntxt.h#l3271

(TriggerOperationCallback is not the same as triggerOperationCallback!)

Looking at the set-up, it seems the obvious thing to do is to make this accessible externally, and set it up as a JS_FRIEND_API function.

As this changes the interfaces, requesting review for this bustage fix (needed for Thunderbird/SeaMonkey trees and non-libxul builds).

Comment 2

[Mark Banner (:standard8)]

Checked in with a=bustage fix, as tinderbox said that was valid.

http://hg.mozilla.org/mozilla-central/rev/2ef97f492c59