Closed Bug 598316 Opened 11 years ago Closed 11 years ago

Comparison between signed and unsigned integers in nsHTMLFieldSetElement::InsertChildAt

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
In |aIndex <= IndexOf(mFirstLegend)|, aIndex is unsigned and IndexOf(mFirstLegend) is signed. Mounir, this one is yours.
Flags: in-testsuite-
Attachment #477119 - Flags: review?
Attachment #477119 - Flags: review? → review?(mounir.lamouri)
Attachment #477119 - Flags: review?(mounir.lamouri) → review+
Attachment #477119 - Flags: approval2.0?
Attachment #477119 - Flags: approval2.0? → approval2.0+
Attachment #477119 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ce62f87104e1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Backed out due to orange:

http://hg.mozilla.org/mozilla-central/rev/c56b47b3b6c7
http://hg.mozilla.org/mozilla-central/rev/defdd7460560
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Orange should be fixed now.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/094d838ed780
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.