598373 - The new addon/piston tests don't work by default

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Jeff Balogh (:jbalogh)]

======================================================================
ERROR: test_update (zamboni.apps.api.tests.test_oauth.TestAddon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jeff/dev/zamboni/../zamboni/apps/api/tests/test_oauth.py", line 276, in test_update
    data = json.loads(r.content)
  File "/usr/local/Cellar/python/2.6.4/lib/python2.6/json/__init__.py", line 307, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/2.6.4/lib/python2.6/json/decoder.py", line 319, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/Cellar/python/2.6.4/lib/python2.6/json/decoder.py", line 338, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

======================================================================
FAIL: test_create (zamboni.apps.api.tests.test_oauth.TestAddon)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jeff/dev/zamboni/../zamboni/apps/api/tests/test_oauth.py", line 257, in test_create
    eq_(r.status_code, 200, r.content)
  File "/Users/jeff/dev/zamboni/vendor/lib/python/nose/tools.py", line 31, in eq_
    assert a == b, msg or "%r != %r" % (a, b)
AssertionError: Piston/0.2.3rc1 (Django 1.2.1) crash report:

Traceback (most recent call last):

  File "/Users/jeff/dev/zamboni/vendor/src/django/django/db/transaction.py", line 299, in _commit_on_success
    res = func(*args, **kw)

  File "/Users/jeff/dev/zamboni/vendor/src/django-piston/piston/utils.py", line 150, in wrap
    return f(self, request, *args, **kwargs)

  File "/Users/jeff/dev/zamboni/apps/api/handlers.py", line 67, in create
    license_id=license_id)

  File "/Users/jeff/dev/zamboni/apps/versions/forms.py", line 166, in create_addon
    self._save_file(version)

  File "/Users/jeff/dev/zamboni/apps/versions/forms.py", line 176, in _save_file
    os.mkdir(path)

OSError: [Errno 2] No such file or directory: '/warez/15680'


----------------------------------------------------------------------
Ran 661 tests in 374.963s

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

You need to setup your ADDONS_PATH... not sure if the test should do that for you.

Comment 2

[Jeff Balogh (:jbalogh)]

Tests should work out of the box as much as possible.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

http://github.com/jbalogh/zamboni/commit/545c039