Calling remove() on a PopupNotification leaves the icon in the URL bar until page is refocused

VERIFIED FIXED in mozilla2.0b10

Status

()

Toolkit
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Ben Turner (not reading bugmail, use the needinfo flag!), Assigned: Gavin)

Tracking

Trunk
mozilla2.0b10
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking2.0 -, status2.0 wanted)

Details

(Whiteboard: [doorhanger])

Attachments

(1 attachment)

If the browser is in the background with a PopupNotification icon displayed in the URL bar, then remove() is called on the notification from a timer, the icon will stay in the URL bar until I refocus the browser. It then disappears. Found when doing bug 595253.
Created attachment 497704 [details] [diff] [review]
patch

We were failing to update on removal if the panel wasn't open, which is rather bogus.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #497704 - Flags: review?(dtownsend)
blocking2.0: --- → final+
blocking2.0: final+ → -

Comment 2

8 years ago
Will take the patch, but not serious enough to be a blocker.
status2.0: --- → wanted
Attachment #497704 - Flags: review?(dtownsend)
Attachment #497704 - Flags: review+
Attachment #497704 - Flags: approval2.0+
https://hg.mozilla.org/mozilla-central/rev/93e038700b05

I had to make some further test tweaks because of bug 610130 (mostly removing notifications that previous tests failed to remove, and adjusting test 9's onhidden handlers to ignore the first rather than the second hidden event).
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
Whiteboard: [doorhanger]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.