Silence some compiler warnings in nativegen.py-generated code

RESOLVED FIXED

Status

Tamarin
Virtual Machine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Some "helpful" compilers will now issue a warning:

    "all member functions in class Foo are private"

This applies to SlotOffsetsAndAsserts when built in non-Debug builds, and since some builds enable warnings-as-errors, we need to silence this warning.
(Assignee)

Comment 1

7 years ago
Created attachment 477251 [details] [diff] [review]
Patch

Amazingly useless warning, IMHO, but easier to silence it this way than to fight with a bunch of different project files...
Assignee: nobody → stejohns
Attachment #477251 - Flags: review?(edwsmith)
See also bug 590112, comment 4

(It looks to me like Steven adopted a different approach in attachment 477251 [details] [diff] [review] than I did in attachment 469027 [details] [diff] [review] )

Comment 3

7 years ago
Comment on attachment 477251 [details] [diff] [review]
Patch

I think I ran into that with gcc 4.4 on ubuntu 10.04, and i worked around it by changing "private" to "protected.  (shrug).

if you do it this way, best if you say what compiler and what platform specifically is being appeased.  We've been asking that for all such appeasement tweaks.

Updated

7 years ago
Attachment #477251 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 4

7 years ago
(In reply to comment #2)
> See also bug 590112, comment 4

Doh, somehow I didn't notice that bug. 

Pushed my change (with comment mod) as 5231:45e7ba7fd238
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.