598660 - append version string to info/collections once per day

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Mike Connor [:mconnor]]

We do this in FxSync, see http://mxr.mozilla.org/services-central/source/fx-sync/services/sync/modules/service.js#1363

I think we should discuss how to deal with version + client name here, and possibly have two params.

Comment 1

[Ragavan S [:rags]]

That sounds good. Do you have a proposal for what you would like to see in Firefox Home? I would like to get this in for our next release so we can get better metrics.

Comment 2

[Mike Connor [:mconnor]]

In an ideal world, we'll make FxHome behaviour sane, and we can do the same thing as FxSync.  FxHome, as currently set up, doesn't touch info/collections, so I guess if we can issue a pointless info/collections get with ?client=FxHome&v=<version> that'll work for a stopgap.

Comment 3

[Ragavan S [:rags]]

(In reply to comment #2)
> In an ideal world, we'll make FxHome behaviour sane, and we can do the same
> thing as FxSync.  FxHome, as currently set up, doesn't touch info/collections,
> so I guess if we can issue a pointless info/collections get with
> ?client=FxHome&v=<version> that'll work for a stopgap.

That works for me as an interim solution as well.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Implemented as http://hg.mozilla.org/services/fx-home/rev/a8a33a1e2fea

Comment 5

[Tony Chung [:tchung]]

Stefan, can can this be tested?

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Not sure about a good way to test this. What you can do is use the app for a couple of days and then ask the server guys to grep for all info/collections requests made by your account.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

asked atoll for a tracing of the server-side username.

"GET /1.0/<id>/storage/crypto/clients HTTP/1.1" 200 540 "-" "FirefoxHome/1.0.4b4 CFNetwork/459 Darwin/10.0.0d3"

Verified