Closed
Bug 598725
Opened 14 years ago
Closed 14 years ago
command line debugger riddled with GC issues
Categories
(Tamarin Graveyard :: Debugger, defect)
Tamarin Graveyard
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: treilly, Assigned: treilly)
References
Details
Attachments
(1 file)
5.20 KB,
patch
|
rreitmai
:
review+
lhansen
:
superreview+
|
Details | Diff | Splinter Review |
Missing write barrier abound
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #477622 -
Flags: review? → review?(rreitmai)
Comment 2•14 years ago
|
||
Comment on attachment 477622 [details] [diff] [review] Fixes issues r+ ; nit technically DebugFrame was an interface, but since there are no other implementations this is probably moot. Best to check that the player code compiles (and works) with these changes as saying its fickle in this area is an understatement.
Attachment #477622 -
Flags: review?(rreitmai) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #477622 -
Flags: superreview?(lhansen)
Assignee | ||
Comment 3•14 years ago
|
||
player builds and debugging from FB works
Comment 4•14 years ago
|
||
Comment on attachment 477622 [details] [diff] [review] Fixes issues Neat. It wouldn't have saved us here because of the missing base classes but we could add DEBUG-only constructors in GCObject and GCFinalizedObject that assert that 'this' is a pointer to a GC object, it catches constructor calls where the (gc) parameter is left off, and it catches errors where a GC object is used as a member in some other object. (In particular it will find some bugs around abuse of HeapHashtable and its subclasses in the Flash Player - I have an assert like that in the exact tracing work, where it's needed for correctness, and I've run into some.)
Attachment #477622 -
Flags: superreview?(lhansen) → superreview+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/79199cbcd20e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•