Closed Bug 598725 Opened 14 years ago Closed 14 years ago

command line debugger riddled with GC issues

Categories

(Tamarin Graveyard :: Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: treilly, Assigned: treilly)

References

Details

Attachments

(1 file)

Missing write barrier abound
Attached patch Fixes issuesSplinter Review
Assignee: nobody → treilly
Status: NEW → ASSIGNED
Attachment #477622 - Flags: review?
Attachment #477622 - Flags: review? → review?(rreitmai)
Blocks: 597577
Comment on attachment 477622 [details] [diff] [review]
Fixes issues

r+ ; nit technically DebugFrame was an interface, but since there are no other implementations this is probably moot.

Best to check that the player code compiles (and works) with these changes as saying its fickle in this area is an understatement.
Attachment #477622 - Flags: review?(rreitmai) → review+
Attachment #477622 - Flags: superreview?(lhansen)
player builds and debugging from FB works
Comment on attachment 477622 [details] [diff] [review]
Fixes issues

Neat.

It wouldn't have saved us here because of the missing base classes but we could add DEBUG-only constructors in GCObject and GCFinalizedObject that assert that 'this' is a pointer to a GC object, it catches constructor calls where the (gc) parameter is left off, and it catches errors where a GC object is used as a member in some other object.  (In particular it will find some bugs around abuse of HeapHashtable and its subclasses in the Flash Player - I have an assert like that in the exact tracing work, where it's needed for correctness, and I've run into some.)
Attachment #477622 - Flags: superreview?(lhansen) → superreview+
http://hg.mozilla.org/tamarin-redux/rev/79199cbcd20e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: